[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: strange behaviour from 'mount -an'...
From:       Rob Landley <rob () landley ! net>
Date:       2006-06-24 17:56:07
Message-ID: 200606241356.07482.rob () landley ! net
[Download RAW message or body]

On Friday 23 June 2006 7:03 pm, Andre wrote:
> Rob Landley <rob@landley.net> wrote:
> > On Thursday 22 June 2006 7:13 pm, Andre wrote:
> > > util-linux/nfsmount.o is different (missing header file):
> > >
> > > --- util-linux/nfsmount.c  2006-06-21 00:20:48.000000000 -0700
> > > +++ util-linux/nfsmount.c  2006-06-22 16:14:45.000000000 -0700
> > > @@ -30,6 +30,7 @@
> > >  #include <string.h>
> > >  #include <errno.h>
> > >  #include <time.h>
> > > +#include <sys/socket.h>
> >
> > Are you actually seeing a problem here, or are you just assuming
> > you need it?
>
> I didn't fabricate the compiler warning, if that's what you're asking
> ?!?. Quoted here again for reference:

Ok, I didn't see that one last time.

> > In my headers that's already included by <netinet/in.h>.
>
> It's missing in all versions of uclibc prior to 2006/02/22

I'll just add it to libbb.h.  (I'm already got some other common headers in 
there in my copy...)

> http://uclibc.org/cgi-bin/viewcvs.cgi/trunk/uClibc/include/netinet/in.h?rev
>=14194&view=log
>
> > If yours don't include that, we either need a platform.h entry
> > for your platform or to add an explicit #include for that in
> > libbb.h.
>
> Are you sure ?? There seem to be a whole bunch of busybox sources
> which already include <sys/socket.h> directly.

There are lots of things that #include <stdlib.h> directly, and libbb.h has 
included that for years.  We only started cleaning this up recently.

> Why should nfsmount.c be different ??

Because I've been slowly cleaning this up as I have other reasons to touch the 
file?

> Andre
> --

Rob
-- 
Never bet against the cheap plastic solution.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]