[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: svn commit: trunk/busybox/archival/libunarchive
From:       Rob Landley <rob () landley ! net>
Date:       2006-05-30 19:49:46
Message-ID: 200605301549.47403.rob () landley ! net
[Download RAW message or body]

On Tuesday 30 May 2006 8:06 am, Peter Kjellerstedt wrote:
> > Log:
> > I noticed that "tar tvjf file.tbz" was segfaulting.  This fixed it.
> >
> >
> > Modified:
> >    trunk/busybox/archival/libunarchive/header_verbose_list.c
> >
> > Changeset:
> > Modified: trunk/busybox/archival/libunarchive/header_verbose_list.c
> > ===================================================================
> > --- trunk/busybox/archival/libunarchive/header_verbose_list.c
> > 2005-11-12 01:15:04 UTC (rev 12223)
> > +++ trunk/busybox/archival/libunarchive/header_verbose_list.c
> > 2005-11-12 02:54:06 UTC (rev 12224)
> > @@ -6,7 +6,7 @@
> >
> >  extern void header_verbose_list(const file_header_t *file_header)
> >  {
> > -	struct tm *mtime = localtime(&file_header->mtime);
> > +	struct tm *mtime = localtime(&(file_header->mtime));
> >
> >  	printf("%s %d/%d%10u %4u-%02u-%02u %02u:%02u:%02u %s",
> >  		bb_mode_string(file_header->mode),
>
> How can this possibly make any difference at all?  The -> operator
> already has a higher precedence than the & operator, so the
> parenthesises should change nothing.  Or am I missing something?

Dunno.  Try removing it and tell me what's happening.  All I know is I tracked 
the problem down and that fixed it...

Rob
-- 
Never bet against the cheap plastic solution.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]