[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: svn 11464: why?
From:       Rob Landley <rob () landley ! net>
Date:       2006-02-24 19:19:39
Message-ID: 200602241419.39453.rob () landley ! net
[Download RAW message or body]

On Friday 24 February 2006 11:44 am, Mike Frysinger wrote:
> On Friday 24 February 2006 11:09, Vladimir N. Oleynik wrote:
> > > The patch's description says it's to speed up compiles, but I benched
> > > it here and including regex.h is slightly less expensive than include
> > > stdio.h, which isn't exactly something we avoid doing...
> >
> > You tested sed only?
> > Before this patch ALL applets compiled with include <regex.h>
> > Current: only required xregex() function.
>
> you're benching how long it takes to compile busybox now ?  and you're
> saying that including regex.h makes some kind of appreciable difference in
> compile times ?
> -mike

The checkin comment said the reason for splitting it out was to make the 
compile faster.  I thought that was weird, so I checked it.

Mostly I was just wondering why it's nonstandard.  It's neither using the 
standard #include <regex.h> nor the busybox local standard #include 
"libbb.h", but instead it's its own header file containing exactly one 
function prototype.

Rob
-- 
Never bet against the cheap plastic solution.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]