[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: busybox e2fsprogs on powerpc
From:       Rob Landley <rob () landley ! net>
Date:       2006-01-23 21:39:05
Message-ID: 200601231539.06033.rob () landley ! net
[Download RAW message or body]

On Monday 23 January 2006 14:15, Ken McGuire wrote:
> > Our CONFIG_ infrastructure is migrating to ENABLE_, and I'm pretty sure
> > that when I added that the e2fs code that used ENABLE_SWAPFS hadn't gone
> > in yet. (Not that we're likely to have a CONFIG_SWAPFS, but still.) 
> > Possibly I should rename ENABLE_SWAPFS to something else...
>
> EXT2_ENABLE_SWAPFS, ENABLE_SWAPFS, WORDS_BIGENDIAN, __BIG_ENDIAN are all
> confusing to me, as they seem to relate to the same thing. I guess you
> might want to build a special form of mkfs that could run on x86 and
> produce a fs for ppc, but as part of busybox... ???

Now you know why I'm dying to do a crapectomy on this thing, but first I have 
to A) catch up with dayjobness and B) fight down the list of actual bugs.

> >
> > Just confirming: you define WORDS_BIGENDIAN above, but need the separate
> > __BYTE_ORDER check later?
>
> I did not check removing the later __BYTE_ORDER check. A bit of code review
> might be in order, but reading the e2fsprogs code hurts my head..

Mine too.  I'm leaving it all in there for now pending said crapectomy.

Applied: try svn 13536 and tell me what I broke.

Rob
-- 
Steve Ballmer: Innovation!  Inigo Montoya: You keep using that word.
I do not think it means what you think it means.
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]