[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] loop.c broken since r10901
From:       Rob Landley <rob () landley ! net>
Date:       2005-07-28 17:10:40
Message-ID: 200507281210.40971.rob () landley ! net
[Download RAW message or body]

On Wednesday 27 July 2005 09:24, Paul Fox wrote:
>  > Hello list,
>  >
>  > revision 10901 introduced an ifdef that contains all code in
>  > "libbb/loop.c".  As
>  >
>  >  #ifdef CONFIG_FEATURE_MOUNT_LOOP
>  >
>  > is the first non-comment line there is no chance for
>  > CONFIG_FEATURE_MOUNT_LOOP to be defined.
>  >
>  > Please consider to add "#include <libbb.h>" before the #ifdef.
>
> or, move the ifdef after the already-present include line.
> commited in 10933.  this is the quick fix, possibly the right
> fix, but it sounds like rob will turn it upside down soon
> anyway...

Sorry, didn't mean to growl earlier, I'm just getting frustrated.  (I _said_ 
this file is cursed...)

Rob


_______________________________________________
busybox mailing list
busybox@mail.busybox.net
http://codepoet.org/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]