[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] coreutils/watch.c: use perror instead of error,
From:       Rob Landley <rob () landley ! net>
Date:       2005-05-28 22:33:41
Message-ID: 200505281833.41819.rob () landley ! net
[Download RAW message or body]

On Thursday 26 May 2005 05:35 pm, Shaun Jackman wrote:
> This patch uses perror instead of error to give a better error message
> to the user. It avoids checking the return value of execvp since it's
> always -1 (says POSIX), reducing the code size by a conditional jump.

If we ever continue past exec, then it failed.  No need to test for it. :)

> Finally, using perror instead of error reduces the rodata size by a
> few bytes by using terse but more helpful messages (string constants).
>
> Cheers,
> Shaun

It failed to apply because whitespace was mangled, but I fixed it up by hand.

Applied.

Rob
_______________________________________________
busybox mailing list
busybox@mail.busybox.net
http://codepoet.org/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]