[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] [PATCH] Add -b and -S flags to ln.c.
From:       Rob Landley <rob () landley ! net>
Date:       2005-04-29 21:11:48
Message-ID: 200504291711.48390.rob () landley ! net
[Download RAW message or body]

> Regardless, an updated patch is attached.

Which starts:

--- ./coreutils/ln.c.orig       2005-04-18 09:39:59.000000000 -0600
+++ ./coreutils/ln.c    2005-04-18 09:42:39.000000000 -0600
@@ -21,21 +21,31 @@

Once again, kernel diff format please.  (Although I did get this one to apply 
by hand.  Possibly specifying a path to the file starting with ./ is what 
works...)

By the way: I moved the in-file change comments into the source control 
checkin comment.  (Including Manuel's old one.)  Personally I think that now 
that we have web-browseable source control, having a changelog at the top of 
the file itself is just bloat.  It's not updated with every checkin (you 
yourself didn't put a note on usage.h), and what entries are there tend not 
to reflect the contents of the current file after a while, since later 
changes mask or even totally obsolete them.

Comments in source control are much better because you can get a 
version-specific diff to see what this change actually _did_...

Rob
_______________________________________________
busybox mailing list
busybox@mail.busybox.net
http://codepoet.org/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]