[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [BusyBox] [PATCH] Do not export all make variables
From:       "Peter Kjellerstedt" <peter.kjellerstedt () axis ! com>
Date:       2004-10-27 10:01:24
Message-ID: 50BF37ECE4954A4BA18C08D0C2CF88CB7D71E8 () exmail1 ! se ! axis ! com
[Download RAW message or body]

This patch removes the export of all make variables by default.
Instead it just exports what is necessary (in this case $(srctree)
needs to be exported for the configuration tool to work).

The reason for this is that at least the version of make that
I use (gmake 3.79.1) exported the $(skip-makefile) variable
even though it contains a dash (which the make manual states 
that it should not do). I could have used unexport for this
variable, but since I have experienced problems with exporting
all variables by default before, I preferred to do it this 
way instead.
 
//Peter
 <<export.patch>> 

["export.patch" (application/octet-stream)]

? export.patch
? install.patch
Index: Makefile
===================================================================
RCS file: /var/cvs/busybox/Makefile,v
retrieving revision 1.299
diff -p -u -r1.299 Makefile
--- Makefile	13 Oct 2004 17:45:57 -0000	1.299
+++ Makefile	27 Oct 2004 09:49:41 -0000
@@ -34,7 +34,7 @@ ifndef top_builddir
 top_builddir=$(CURDIR)
 endif
 
-srctree=$(top_srcdir)
+export srctree=$(top_srcdir)
 vpath %/Config.in $(srctree)
 
 include $(top_builddir)/Rules.mak
Index: Rules.mak
===================================================================
RCS file: /var/cvs/busybox/Rules.mak,v
retrieving revision 1.39
diff -p -u -r1.39 Rules.mak
--- Rules.mak	8 Oct 2004 10:52:33 -0000	1.39
+++ Rules.mak	27 Oct 2004 09:49:41 -0000
@@ -190,7 +190,3 @@ endif
 CFLAGS += $(CFLAGS_EXTRA)
 
 .PHONY: dummy
-
-
-.EXPORT_ALL_VARIABLES:
-


_______________________________________________
busybox mailing list
busybox@mail.busybox.net
http://codepoet.org/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]