[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] Segfault while insmod
From:       Friedrich Lobenstock <fl () fl ! priv ! at>
Date:       2003-12-28 22:50:45
[Download RAW message or body]

Bachmann Markus wrote on 28.12.2003 18:00 MET:
> Busybox configurated with 2.4 and 2.6 module support crash while loading a
> 2.4 module. I have fixed the problem with the modification below insmod line
> 4136.
> 
> Original code
> #if defined(CONFIG_FEATURE_2_6_MODULES)
> 	if (k_version > 4)
> 		bb_xasprintf(&m_fullName, "%s.ko", tmp);
> 	else
> #else
>     bb_xasprintf(&m_fullName, "%s.o", tmp);
> #endif
> 
> New code
> #if defined(CONFIG_FEATURE_2_6_MODULES)
> 	if (k_version > 4)
> 		bb_xasprintf(&m_fullName, "%s.ko", tmp);
> 	else
>         bb_xasprintf(&m_fullName, "%s.o", tmp);
> #else
>     bb_xasprintf(&m_fullName, "%s.o", tmp);
> #endif

That looks to me as if the "#endif" should have been placed
at the place of the "#else".

-- 
MfG / Regards
Friedrich Lobenstock



_______________________________________________
busybox mailing list
busybox@mail.busybox.net
http://codepoet.org/mailman/listinfo/busybox


[prev in list] [next in list] [prev in thread] [next in thread]