[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] Bug in httpd.c
From:       "Vladimir N. Oleynik" <dzo () simtreas ! ru>
Date:       2003-06-23 15:12:48
[Download RAW message or body]

I wrote:

>> Hello, I think the test for an unconfigured httpd is wrong in
>> the CVS (busybox-unstable-20030620.tar.bz2)
>>
>> flg_deny_all is default 0
> 
> 
> Oops. You are right.
> Also, this mistake haved from two place.
> Last patch rewroted to my new get_ularg() function for overcompensate size
> from this error found ;-)

And quick changes to last_patch after realy strong testing from attach ;-)


--w
vodz


["qpatch" (text/plain)]

diff -ru busybox.orig/libbb/login.c busybox/libbb/login.c
--- busybox.orig/libbb/login.c	2003-05-25 15:48:37.000000000 +0400
+++ busybox/libbb/login.c	2003-06-23 18:56:03.000000000 +0400
@@ -45,7 +45,7 @@
 	time(&t);
 	uname(&uts);
 
-	puts("");       /* start a new line */
+	puts("\r");       /* start a new line */
 
 	if ((fd = fopen(issue_file, "r"))) {
 		while ((c = fgetc(fd)) != EOF) {
diff -ru busybox.orig/networking/httpd.c busybox/networking/httpd.c
--- busybox.orig/networking/httpd.c	2003-06-23 13:14:11.000000000 +0400
+++ busybox/networking/httpd.c	2003-06-23 18:26:46.000000000 +0400
@@ -1790,7 +1790,7 @@
   config->ContentLength = -1;
 
   opt = bb_getopt_ulflags(argc, argv, httpd_opts,
-			&(config->configFile), &home_httpd, &url_for_decode
+			&(config->configFile), &url_for_decode, &home_httpd
 #ifdef CONFIG_FEATURE_HTTPD_ENCODE_URL_STR
 			, &url_for_encode
 #endif


[prev in list] [next in list] [prev in thread] [next in thread]