[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [BusyBox] [patch] broken 'struct serial' in init.c
From:       Andrew Clausen <clausen () melbourne ! sgi ! com>
Date:       2003-02-21 20:39:03
[Download RAW message or body]

Hi all,

Please cc me, I'm not subscribed.

The local copy of "struct serial_struct" in init.c is not the same as that
from <linux/serial.h>, contrary to the comment nearby.

This causes init to crash on my Origin 200 during a Debian install.
I'm surprised no-one else has noticed it.  I'm probably the first
person to do a Debian mips64 install, but I think it should affect
all architectures.

My patch below deletes irrelevant parts of the struct, and adds
a big array that we can safely assume won't get overrun.  ioctl's
are evil :(

Cheers,
Andrew


diff -u busybox-0.60.2.orig/init.c busybox-dev/init.c
--- busybox-0.60.2.orig/init.c	Tue Nov 20 16:43:28 2001
+++ busybox-dev/init.c	Thu Feb 20 21:04:14 2003
@@ -63,15 +63,8 @@
 	int     port;
 	int     irq;
 	int     flags;
-	int     xmit_fifo_size;
-	int     custom_divisor;
-	int     baud_base;
-	unsigned short  close_delay;
-	char    reserved_char[2];
-	int     hub6;
-	unsigned short  closing_wait; /* time to wait before closing */
-	unsigned short  closing_wait2; /* no longer used... */
-	int     reserved[4];
+	int     ignored[2048];		/* stuff we don't care about, and room for
+								   growth... */
 };
 
 

[prev in list] [next in list] [prev in thread] [next in thread]