[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [BusyBox] bug#1280: marked as done (Makefile contains a typo?)
From:       owner () busybox ! net (BusyBox ! net bug Tracking System)
Date:       2002-10-26 4:21:03
[Download RAW message or body]

Your message dated Sat, 26 Oct 2002 04:15:38 -0600
with message-id <20021026101538.GB7483@codepoet.org>
and subject line [BusyBox] bug#1280: Makefile contains a typo?
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Erik Andersen
(administrator, BusyBox.net bugs database)

--------------------------------------
Received: (at submit) by bugs.busybox.net; 26 Oct 2002 09:31:32 +0000
>From pin@math.chalmers.se  Sat Oct 26 03:31:32 2002
Received: by winder.codepoet.org (Postfix, from userid 104)
	id 899F41579E2; Sat, 26 Oct 2002 03:31:31 -0600 (MDT)
Received: from pheidippides.md.chalmers.se (pheidippides.md.chalmers.se [129.16.237.91])
	by winder.codepoet.org (Postfix) with ESMTP id 6A9D81575AB
	for <submit@bugs.busybox.net>; Sat, 26 Oct 2002 03:31:25 -0600 (MDT)
Received: from hotlips.cs.chalmers.se (hotlips.cs.chalmers.se [129.16.225.36])
	by pheidippides.md.chalmers.se (8.10.1/8.10.1) with ESMTP id g9Q9VLl17508
	for <submit@bugs.busybox.net>; Sat, 26 Oct 2002 11:31:21 +0200 (MET DST)
Received: from localhost (pin@localhost)
	by hotlips.cs.chalmers.se (8.8.5/8.8.5) with ESMTP id LAA07039
	for <submit@bugs.busybox.net>; Sat, 26 Oct 2002 11:31:22 +0200 (MET DST)
X-Authentication-Warning: hotlips.cs.chalmers.se: pin owned process doing -bs
Date: Sat, 26 Oct 2002 11:31:22 +0200 (MET DST)
From: Ivan Popov <pin@math.chalmers.se>
To: <submit@bugs.busybox.net>
Subject: Makefile contains a typo?
Message-ID: <Pine.SOL.4.30.0210261130350.2005-100000@hotlips.cs.chalmers.se>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Spam-Status: No, hits=-0.9 required=5.0
	tests=PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01,USER_AGENT_PINE,
	      X_AUTH_WARNING
	version=2.43
X-Spam-Level: 

Package: busybox
Version: 0.60.4

The suggested change:

--- Makefile.ori        Sat Oct 26 10:40:16 2002
+++ Makefile    Sat Oct 26 10:43:14 2002
@@ -200,7 +201,7 @@
     #endif
 endif

-ifndef $(PREFIX)
+ifndef PREFIX
     PREFIX = `pwd`/_install
 endif


I am using Debian 3.0, kernel version 2.4.19, and uClibc 0.9.15.
Thanks for the wonderful program!
        -Diligent^H^H^H^H^H^H^H^HIvan
:-)

---------------------------------------
Received: (at 1280-done) by bugs.busybox.net; 26 Oct 2002 10:15:40 +0000
>From andersen@codepoet.org  Sat Oct 26 04:15:39 2002
Received: by winder.codepoet.org (Postfix, from userid 1000)
	id D53BC157ACD; Sat, 26 Oct 2002 04:15:38 -0600 (MDT)
Date: Sat, 26 Oct 2002 04:15:38 -0600
From: Erik Andersen <andersen@codepoet.org>
To: Ivan Popov <pin@math.chalmers.se>, 1280-done@bugs.busybox.net
Subject: Re: [BusyBox] bug#1280: Makefile contains a typo?
Message-ID: <20021026101538.GB7483@codepoet.org>
Reply-To: andersen@codepoet.org
References: <Pine.SOL.4.30.0210261130350.2005-100000@hotlips.cs.chalmers.se>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.SOL.4.30.0210261130350.2005-100000@hotlips.cs.chalmers.se>
User-Agent: Mutt/1.3.28i
X-Operating-System: Linux 2.4.19-rmk2, Rebel-NetWinder(Intel StrongARM 110 rev 3), 185.95 BogoMips
X-No-Junk-Mail: I do not want to get *any* junk mail.

On Sat Oct 26, 2002 at 11:31:22AM +0200, Ivan Popov wrote:
> Package: busybox
> Version: 0.60.4
> 
> The suggested change:
> 
> --- Makefile.ori        Sat Oct 26 10:40:16 2002
> +++ Makefile    Sat Oct 26 10:43:14 2002
> @@ -200,7 +201,7 @@
>      #endif
>  endif
> 
> -ifndef $(PREFIX)
> +ifndef PREFIX
>      PREFIX = `pwd`/_install
>  endif

Hmm.  Thanks for noticing this.  I think I will do 
this instead, which should work nicely I think.

-ifndef $(PREFIX)
+ifeq ($(strip $(PREFIX)),)
     PREFIX = `pwd`/_install
endif

> 
> I am using Debian 3.0, kernel version 2.4.19, and uClibc 0.9.15.
> Thanks for the wonderful program!
>         -Diligent^H^H^H^H^H^H^H^HIvan
> :-)

You are very welcome!  :-)

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--

[prev in list] [next in list] [prev in thread] [next in thread]