[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    bug#1229: [BusyBox] bug#1229: undefined junk in grep
From:       Matt Kraai <kraai () alumni ! cmu ! edu>
Date:       2002-02-21 10:01:06
[Download RAW message or body]


On Thu, Feb 21, 2002 at 02:38:01PM +0000, Richard Lightman wrote:
> Package: busybox
> Version: 0.60.2
> Severity: normal
> 
> Defining BB_FEATURE_GREP_EGREP_ALIAS but not BB_FEATURE_GREP_CONTEXT
> gives a compile error:
> 
> gcc -Wall -Wshadow -Os -fomit-frame-pointer -D_GNU_SOURCE  -DBB_VER='"0.60.2"' \
>                 -DBB_BT='"2002.02.21-14:32+0000"' -DUSE_SYSTEM_PWD_GRP  -I.  -c \
>                 grep.c -o grep.o
> grep.c: In function `grep_main':
> grep.c:247: `junk' undeclared (first use in this function)
> grep.c:247: (Each undeclared identifier is reported only once
> grep.c:247: for each function it appears in.)
> make: *** [grep.o] Error 1
> 
> The fix is trivial:
> 
> diff -urN busybox-0.60.2/grep.c busybox-0.60.2-grep/grep.c
> --- busybox-0.60.2/grep.c       Tue Nov 20 00:23:19 2001
> +++ busybox-0.60.2-grep/grep.c  Thu Feb 21 14:17:50 2002
> @@ -234,7 +234,7 @@
> extern int grep_main(int argc, char **argv)
> {
> int opt;
> -#ifdef BB_FEATURE_GREP_CONTEXT
> +#if defined(BB_FEATURE_GREP_CONTEXT) || defined(BB_FEATURE_GREP_EGREP_ALIAS)
> char *junk;
> #endif

This was fixed in CVS two months ago.  Perhaps we need a new
release?  :)

Matt


[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]