[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] Tar problems continue
From:       Matt Kraai <kraai () alumni ! cmu ! edu>
Date:       2002-02-17 11:45:04
[Download RAW message or body]


On Fri, Feb 15, 2002 at 03:21:16PM +1100, Glenn McGrath wrote:
> On Thu, 14 Feb 2002 10:08:47 -0800
> "Richard Doyle" <rdoyle@islandnetworks.com> wrote:
> > I'm still getting odd behavior from tar in the unstable branch of
> > BusyBox (tar.c dated Feb 12 20:45), compiled under uClibc. Busybox tar
> > improperly handles the list of files to be processed when creating a
> tar> file: absolute paths are required, and only the last file or
> directory> in the list of files is added to the tarfile.
> > 
> 
> I fixed a bug (fix is in CVS) where the lists of files to be included
> and excluded wernt being passed properly to writeTarFile(). Im a little
> surprised any files were being added... i hope there arent more bugs
> lurking in there. 

Here is the regression test I created to prevent this from
cropping up in the future:

touch foo bar
busybox tar cf foo.tar foo bar
rm foo bar
tar xf foo.tar
test -f foo -a -f bar

*Please* add regression tests for bugs that you fix if it is easy
to do so.  

Matt

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]