[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [BusyBox] dos2unix
From:       Larry Doolittle <ldoolitt () recycle ! lbl ! gov>
Date:       2001-01-29 18:45:03
[Download RAW message or body]

Jim Gleason asked, about the dos2unix build bug:

> Also, how did this get by in testing or was this piece ever tested?

Simple.  The test program is buggy :-)
(And that is my fault.  Consider this a Hubble-style bug.)

Applet names containing digits (dos2unix, md5sum, unix2dos) were
not properly handled by tests/multibuild.pl.  The following patch
fixes that:

--- /home/ldoolitt/net/busybox-0.49/tests/multibuild.pl	Wed Jan  3 17:05:55 2001
+++ tests/multibuild.pl	Mon Jan 29 10:38:43 2001
@@ -24,7 +24,7 @@
 		$trailer .= $_;
 	} else {
 		$in_trailer=1 if /End of Applications List/;
-		if (/^\/*#define BB_([A-Z_]*)/) {
+		if (/^\/*#define BB_([A-Z0-9_]*)/) {
 			push @apps, $1;
 		}
 	}



[prev in list] [next in list] [prev in thread] [next in thread]