[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [BusyBox] Re: shell compile cleanup
From:       Erik Andersen <andersen () lineo ! com>
Date:       2000-11-30 21:37:15
[Download RAW message or body]

On Wed Nov 29, 2000 at 07:02:20PM -0800, Bryan Rittmeyer wrote:
> Howdy,
> 
> I just got the latest CVS checkout of BusyBox and was unable to link in
> sh.o:
> 
> sh.o: In function `globLastArgument':
> sh.o(.text+0xc18): undefined reference to `process_escape_sequence'
> collect2: ld returned 1 exit status
> make: *** [busybox] Error 1
> 
> A little grepping around revealed this was a utility.c function which is
> only defined if BB_ECHO or BB_TR are enabled. Since I'm not using either
> of these, the function was never built, and the linker bombed. Here's
> the fixup patch:
> 
> 
> --- utility-virgin.c    Wed Nov 29 18:53:45 2000
> +++ utility.c   Wed Nov 29 18:56:44 2000
> @@ -1676,7 +1676,7 @@
>  }
>  #endif /* BB_CAT */
>  
> -#if defined BB_ECHO || defined BB_TR
> +#if defined BB_ECHO || defined BB_TR || defined BB_SH
>  char process_escape_sequence(char **ptr)
>  {
>         char c;
> 
> 
> I'm assuming the SH dependency on this function is relatively recent and
> wasn't caught because most people usually include echo (if not tr).

oops.  Mea culpa!  I did added this bug yesterday 
(while fixing lash escape char handling).

> I love fixing bugs on this project. They're always minor. Or maybe
> that's just because I'm too lazy, err, busy, to tackle the big ones? =)

:-)

 -Erik

--
Erik B. Andersen   email:  andersen@lineo.com
--This message was written using 73% post-consumer electrons--



[prev in list] [next in list] [prev in thread] [next in thread]