[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] Compile errors on the semi-latest CVS
From:       Matt Kraai <kraai () alumni ! carnegiemellon ! edu>
Date:       2000-10-28 1:24:30
[Download RAW message or body]

David Douthitt wrote:
> I received an error compiling with BB_FEATURE_LS_FILETYPES commented
> out:
> 
> gcc -Wall -O2 -fomit-frame-pointer -D_GNU_SOURCE -DBB_VER='"0.47"' -
> DBB_BT='"2000.10.28-00:42+0000"'   -c ls.c -o ls.o
> ls.c: In function `showdirs':
> ls.c:438: warning: unused variable `dnd'
> ls.c:437: warning: unused variable `dndirs'
> ls.c: In function `list_single':
> ls.c:574: `info' undeclared (first use this function)
> ls.c:574: (Each undeclared identifier is reported only once
> ls.c:574: for each function it appears in.)
> make: *** [ls.o] Error 1

This should now be fixed in CVS.  Attached is the patch (it even gets
rid of the warning).

Matt


Index: ls.c
===================================================================
RCS file: /var/cvs/busybox/ls.c,v
retrieving revision 1.40
diff -u -r1.40 ls.c
--- ls.c	2000/10/13 18:03:21	1.40
+++ ls.c	2000/10/28 01:17:24
@@ -433,7 +433,7 @@
 {
 	int i, nfiles;
 	struct dnode **subdnp;
-#ifdef BB_FEATURE_LS_SORTFILES
+#ifdef BB_FEATURE_LS_RECURSIVE
 	int dndirs;
 	struct dnode **dnd;
 #endif
@@ -529,8 +529,10 @@
 	char *filetime;
 	time_t ttime, age;
 #endif
-#ifdef BB_FEATURE_LS_FILETYPES
+#if defined (BB_FEATURE_LS_FILETYPES) || defined (BB_FEATURE_LS_USERNAME)
 	struct stat info;
+#endif
+#ifdef BB_FEATURE_LS_FILETYPES
 	char append;
 #endif
 


[prev in list] [next in list] [prev in thread] [next in thread]