[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [BusyBox] LinuxSH4 insmod.c for BusyBox
From:       Erik Andersen <andersen () lineo ! com>
Date:       2000-09-24 3:45:02
[Download RAW message or body]

On Wed Sep 20, 2000 at 06:07:53PM -0700, Bryan Rittmeyer wrote:
> Pavel Roskin wrote:
> 
> > In cany case, having different sources for insmod seems to be a bad
> > idea. Look, even in the official modutils there is only one insmod.c
> 
> I have completed a preliminary patch for BusyBox insmod which produces
> an insmod.c file that compiles and functions correctly on the SH4 in
> little endian mode and on an x86 Linux workstation. Here's the URL:
> 
> http://foobar.caltech.edu/linuxsh4/insmod-sh4.diff
> 
> I am still kind of bothered by the fact that even my version works ONLY
> on the SH4 and x86, and that anybody with an ARM or m68k or PPC kernel
> will have to go in and hack in some more #if define's for their
> architecture. But I can't think of any other way to do it, and at least
> now my patched version has a framework for adding in architecture
> dependent stuff without breaking everybody else.
> 
> Comments?

This looks ok to me.  Applied.

 -Erik

--
Erik B. Andersen   email:  andersen@lineo.com
--This message was written using 73% post-consumer electrons--



[prev in list] [next in list] [prev in thread] [next in thread]