[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    [BusyBox] bug#1032: Confused use of tostdoutFlag in tar.c
From:       David Vrabel <dvrabel () arcom ! co ! uk>
Date:       2000-08-25 9:51:05
[Download RAW message or body]

Package: busybox
Version: 0.46
Severity: wishlist

The use of the tostdoutFlag in tar.c seems confused and inconsistant. 
Particularly when combined with the odd fiddling with tarName.

I propose that the following use be adopted.

*Only* use tostdoutFlag to indicate that the `O' flag was present
Leave tarName to whatever is read from the f option.
When creating a tar file output it to stdout if tarName = "-".
When extracting a tar file read it in from stdin if tarName = "-".
By default tarName should probably be /dev/rmt0 (as in GNU tar).

I'm suggesting these changes since 0.46 tar is broken and I can't work
out if the CVS version fixes the problems.

David Vrabel





[prev in list] [next in list] [prev in thread] [next in thread]