[prev in list] [next in list] [prev in thread] [next in thread] 

List:       buildroot
Subject:    Re: [Buildroot] [PATCH v3 3/8] support/scripts/pkg-stats: check all files for warnings
From:       Daniel Lang <dalang () gmx ! at>
Date:       2023-08-31 19:52:23
Message-ID: 00d15b88-0d94-491e-800c-c36f4a3ddbe7 () gmx ! at
[Download RAW message or body]

Hello Arnout,

On 30.08.23 22:36, Arnout Vandecappelle wrote:
> 
> 
> On 12/08/2023 21:28, Daniel Lang wrote:
> > Instead of only checking .mk and Config.in{,.host}, check
> > all files in a package directory.
> 
> ("checking" here means "run check-package").

Correct.

> 
> I think we should instead remove the .warnings and .status['pkg-check'] fields \
> entirely. It made sense back in the days, because we weren't running check-package \
> in CI. Now, however, we do, so there's little point to run check-package as part of \
> pkg-stats as well. On a.b.o the warnings column will (almost) always be all 0.

It will always be 0 if .checkpackageignore is considered which isn't the case
here. Therefore the warning column would show the number of warnings including
those ignored.
The question of whether or not this information is needed is still relevant.
I just wanted to point out that in my testing the value wasn't 0 for all packages.

> 
> There is the point of people using pkg-stats for their br2-external, but:
> 
> 1. pkg-stats is pretty fragile so users shouldn't be too surprised b some breakage;
> 2. it's very easy for those users to run 'make check-package' instead.
> 
> 
> Do other maintainers have the same opinion?

Seeing as Thomas already agreed, I will prepare the removal, unless other opinions
are raised.

> 
> 
> Regards,
> Arnout

Regards,
Daniel

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot


[prev in list] [next in list] [prev in thread] [next in thread]