[prev in list] [next in list] [prev in thread] [next in thread] 

List:       buildroot
Subject:    Re: [Buildroot] [PATCH] package/gstreamer1/gst1-plugins-good: Optionally select GUDEV
From:       "Yann E. MORIN" <yann.morin.1998 () free ! fr>
Date:       2020-05-31 20:49:02
Message-ID: 20200531204902.GF8737 () scaer
[Download RAW message or body]

Ezequiel, Nicolas, All,

On 2020-05-31 10:53 -0300, Ezequiel Garcia spake thusly:
> From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> 
> Using udev for probes (such as Video4Linux2 devices probes)
> and device monitor greatly improves load time and monitoring performance.
> 
> It also enables hotplug monitoring for cameras.
> 
> Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
> package/gstreamer1/gst1-plugins-good/Config.in            | 1 +
> package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk | 4 ++++
> 2 files changed, 5 insertions(+)
> 
> diff --git a/package/gstreamer1/gst1-plugins-good/Config.in \
> b/package/gstreamer1/gst1-plugins-good/Config.in index 20aebc473e89..be77f5a82e3d \
>                 100644
> --- a/package/gstreamer1/gst1-plugins-good/Config.in
> +++ b/package/gstreamer1/gst1-plugins-good/Config.in
> @@ -295,6 +295,7 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SHOUT2
> config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_V4L2
> 	bool "v4l2"
> 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 # multi planar api
> +	select BR2_PACKAGE_LIBGUDEV if BR2_PACKAGE_HAS_UDEV

The title is a bit misleading: gudev is not optional; instead, it is
forcibly selected when udev is enabled.

> 	help
> 	  elements for Video 4 Linux
> 
> diff --git a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk \
> b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk index \
>                 223af9850897..6878ce6ae85b 100644
> --- a/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> +++ b/package/gstreamer1/gst1-plugins-good/gst1-plugins-good.mk
> @@ -40,6 +40,10 @@ else
> GST1_PLUGINS_GOOD_CONF_OPTS += -Djack=disabled
> endif
> 
> +ifeq ($(BR2_PACKAGE_LIBGUDEV),y)
> +GST1_PLUGINS_GOOD_DEPENDENCIES += libgudev

I think we would also need to add:

    GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=enabled

and the converse when ghudev is not enabled:

    GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-gudev=disabled

Care to check that, and respin please?

Regards,
Yann E. MORIN.

> +endif
> +
> ifeq ($(BR2_PACKAGE_LIBV4L),y)
> GST1_PLUGINS_GOOD_CONF_OPTS += -Dv4l2-libv4l2=enabled
> GST1_PLUGINS_GOOD_DEPENDENCIES += libv4l
> -- 
> 2.26.0.rc2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
> Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot


[prev in list] [next in list] [prev in thread] [next in thread]