[prev in list] [next in list] [prev in thread] [next in thread] 

List:       buildroot
Subject:    Re: [Buildroot] [PATCH v2] unbound: new package
From:       Stefan Ott <stefan () ott ! net>
Date:       2020-04-05 16:24:35
Message-ID: 20200405162435.GA628 () greebo ! asti ! ch
[Download RAW message or body]


On Sat, Apr 04, 2020 at 11:39:16PM +0200, Thomas Petazzoni wrote:
> 
> By convention, we like to have "depends on" before "select". This type
> of coding style convention is verified by "make check-package".
> 
> Also, when there is a dependency on a toolchain feature like this, we
> add a Config.in comment:
> 
> comment "unbound needs a toolchain w/ dynamic library"
> 	depends on BR2_STATIC_LIBS
> 
> I've fixed both small issues and applied.

Thank you.

-- 
Stefan Ott
https://www.ott.net/
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
[prev in list] [next in list] [prev in thread] [next in thread]