[prev in list] [next in list] [prev in thread] [next in thread] 

List:       buildroot
Subject:    Re: [Buildroot] [PATCH 1/2] Revert "package/luvi: bump version to 2.8.0"
From:       Jörg Krause <joerg.krause () embedded ! rocks>
Date:       2018-10-31 17:55:23
Message-ID: 453696296ed4936d016a18fc21914d8677692d31.camel () embedded ! rocks
[Download RAW message or body]

Hi Peter,

On Sat, 2018-10-20 at 19:36 +0200, Peter Korsgaard wrote:
> > > > > > "Jörg" == Jörg Krause <joerg.krause@embedded.rocks> writes:
> 
> > Hi Bernd,
> > On Sat, 2018-10-13 at 10:01 +0200, Bernd Kuhls wrote:
> > > This reverts commit ac6fedda6b43996545ff498cd19a781698a96050.
> > > 
> > > Fixes
> > > http://autobuild.buildroot.net/results/111/11146b138d3d092c3a230d197528d5dbe293e3fc/
> > >  and many others.
> 
> > Does this really fix the issue about missing "c-api/compat-5.3.h" for
> > you? Because it is a luv (not luvi) issue.
> 
> It does not:
> 
> fatal error: c-api/compat-5.3.h: No such file or directory
> #include "c-api/compat-5.3.h"
> ^
> compilation terminated.
> CMakeFiles/luvi.dir/build.make:74: recipe for target \
> 'CMakeFiles/luvi.dir/src/main.c.o' failed make[4]: *** \
> [CMakeFiles/luvi.dir/src/main.c.o] Error 1 CMakeFiles/Makefile2:180: recipe for \
> target 'CMakeFiles/luvi.dir/all' failed make[3]: *** [CMakeFiles/luvi.dir/all] \
> Error 2 Makefile:127: recipe for target 'all' failed
> make[2]: *** [all] Error 2
> package/pkg-generic.mk:229: recipe for target \
> '/home/peko/source/buildroot/output-test/build/luvi-v2.7.6/.stamp_built' failed \
> make[1]: *** [/home/peko/source/buildroot/output-test/build/luvi-v2.7.6/.stamp_built] \
> Error 2 
> > Nevertheless, I am happy about the revert as it takes ages to fetch all
> > submodules.
> 
> Ok, applied with the autobuilder references removed, thanks.
> 
> How should the luv issue be fixed?

I had a look at this issue. luv shouldn't include the compat-5.3.h
header file in luv.h, but in luv.c.

However, this leads to another issue, as luvi is using `luaL_newlib`
from Lua >= 5.2. The was not an issue with the previous version 1.9.1
of luv, as luv.h defined this macro. If luvi is using this non-Lua-5.1
macro, it should provide a definition itself, as the main Lua engine is
LuaJIT.

I've send a PR to upstream [1]. I will wait for feedback until I
propose the patches for luv and luvi to Buildroot.

[1] https://github.com/luvit/luv/pull/310

Best regards,
Jörg Krause


_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot


[prev in list] [next in list] [prev in thread] [next in thread]