[prev in list] [next in list] [prev in thread] [next in thread]
List: buildroot
Subject: Re: [Buildroot] [PATCH 1/1] ti-gfx: pkg-config should also set parent include dir
From: Spenser Gilliland <spenser () gillilanding ! com>
Date: 2014-05-30 19:57:19
Message-ID: CAEBucnDa_EjmUu2buXEA16by0_Wck+sp-RF1Rajc8uSOswb_Zg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Peter,
On May 30, 2014 10:55 AM, "Peter K=C3=BCmmel" <syntheticpp@gmx.net> wrote:
>
> On 30.05.2014 17:31, Spenser Gilliland wrote:
>>
>> Peter,
>>
>> On May 30, 2014 10:00 AM, "Peter K=C3=BCmmel" <syntheticpp@gmx.net <mail=
to:
syntheticpp@gmx.net>> wrote:
>> >
>> > Signed-off-by: Peter K=C3=BCmmel <syntheticpp@gmx.net <mailto:
syntheticpp@gmx.net>>
>>
>> > ---
>> > package/ti-gfx/glesv2.pc | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/package/ti-gfx/glesv2.pc b/package/ti-gfx/glesv2.pc
>> > index 4c70aec..c3846d0 100644
>> > --- a/package/ti-gfx/glesv2.pc
>> > +++ b/package/ti-gfx/glesv2.pc
>> > @@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL
ESv2
>> > Version: 1.9.2188537
>> > Requires:
>> > Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL -lIMGegl
>> > -Cflags: -I${includedir}/GLES2
>> > +Cflags: -I${includedir}/GLES2 -I${includedir}
>> > --
>> > 1.9.1
>> >
>> >
>>
>> Does this fix a package for you? The includedir var should be
/usr/include which is a default include path.
>
>
> Yes, Qt5's cmake files assume /usr/include not /usr/include/GLES2.
>
> I added -I${includedir} instead of removing only "GLES2" because then
nothing will break,
> and the other .pc file also sets both dirs.
> But it seems common practice is to not add the uppercase dir names in the
pkg-congig file.
This patch won't break anything. But it would be nice if you could go back
and reverify this just to be sure.
My reasoning is that, /usr/include is a default include dir which all
compilers should use automatically. There should not be a need to
manually specify it.
However, that's not to say that cmake doesn't disable the default include
dir some how. If that's the case, it may be better to try to fix cmake or
the qt5 packages.
However, If you don't have time to investigate the items above and this
patch fixes the problem then I see no problem in applying it. So, it has my
ack.
Acked by: Spenser Gilliland <spenser@gillilanding.com>
Thanks,
Spenser
>
> Peter
>
>>
>> Thanks,
>> Spenser _______________________________________________
>> > buildroot mailing list
>> > buildroot@busybox.net <mailto:buildroot@busybox.net>
>> > http://lists.busybox.net/mailman/listinfo/buildroot
>>
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
[Attachment #5 (text/html)]
<p dir="ltr">Peter,</p>
<p dir="ltr">On May 30, 2014 10:55 AM, "Peter Kümmel" <<a \
href="mailto:syntheticpp@gmx.net">syntheticpp@gmx.net</a>> wrote:<br> ><br>
> On 30.05.2014 17:31, Spenser Gilliland wrote:<br>
>><br>
>> Peter,<br>
>><br>
>> On May 30, 2014 10:00 AM, "Peter Kümmel" <<a \
href="mailto:syntheticpp@gmx.net">syntheticpp@gmx.net</a> <mailto:<a \
href="mailto:syntheticpp@gmx.net">syntheticpp@gmx.net</a>>> wrote:<br> >> \
><br> >> > Signed-off-by: Peter Kümmel <<a \
href="mailto:syntheticpp@gmx.net">syntheticpp@gmx.net</a> <mailto:<a \
href="mailto:syntheticpp@gmx.net">syntheticpp@gmx.net</a>>><br> >><br>
>> > ---<br>
>> > package/ti-gfx/glesv2.pc | 2 +-<br>
>> > 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>> ><br>
>> > diff --git a/package/ti-gfx/glesv2.pc b/package/ti-gfx/glesv2.pc<br>
>> > index 4c70aec..c3846d0 100644<br>
>> > --- a/package/ti-gfx/glesv2.pc<br>
>> > +++ b/package/ti-gfx/glesv2.pc<br>
>> > @@ -8,4 +8,4 @@ Description: TI Graphics SDK implementation of OpenGL \
ESv2<br> >> > Version: 1.9.2188537<br>
>> > Requires:<br>
>> > Libs: -L${libdir} -lGLESv2 -lGLES_CM -lsrv_um -lusc -lEGL \
-lIMGegl<br> >> > -Cflags: -I${includedir}/GLES2<br>
>> > +Cflags: -I${includedir}/GLES2 -I${includedir}<br>
>> > --<br>
>> > 1.9.1<br>
>> ><br>
>> ><br>
>><br>
>> Does this fix a package for you? The includedir var should be \
/usr/include which is a default include path.<br> ><br>
><br>
> Yes, Qt5's cmake files assume /usr/include not /usr/include/GLES2.<br>
><br>
> I added -I${includedir} instead of removing only "GLES2" because then \
nothing will break,<br> > and the other .pc file also sets both dirs.<br>
> But it seems common practice is to not add the uppercase dir names in the \
pkg-congig file.</p> <p dir="ltr">This patch won't break anything. But it would \
be nice if you could go back and reverify this just to be sure. </p> <p \
dir="ltr">My reasoning is that, /usr/include is a default include dir which all \
compilers should use automatically. There should not be a need to manually \
specify it. </p> <p dir="ltr">However, that's not to say that cmake \
doesn't disable the default include dir some how. If that's the case, it \
may be better to try to fix cmake or the qt5 packages. </p> <p dir="ltr">However, \
If you don't have time to investigate the items above and this patch fixes the \
problem then I see no problem in applying it. So, it has my ack.</p> <p \
dir="ltr">Acked by: Spenser Gilliland <<a \
href="mailto:spenser@gillilanding.com">spenser@gillilanding.com</a>></p> <p \
dir="ltr">Thanks, <br> Spenser</p>
<p dir="ltr">><br>
> Peter<br>
><br>
>><br>
>> Thanks,<br>
>> Spenser _______________________________________________<br>
>> > buildroot mailing list<br>
>> > <a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a> \
<mailto:<a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a>><br> \
>> > <a href="http://lists.busybox.net/mailman/listinfo/buildroot">http://lists.busybox.net/mailman/listinfo/buildroot</a><br>
>><br>
><br>
> _______________________________________________<br>
> buildroot mailing list<br>
> <a href="mailto:buildroot@busybox.net">buildroot@busybox.net</a><br>
> <a href="http://lists.busybox.net/mailman/listinfo/buildroot">http://lists.busybox.net/mailman/listinfo/buildroot</a></p>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic