[prev in list] [next in list] [prev in thread] [next in thread] 

List:       buildroot
Subject:    Re: [Buildroot] [PATCH v13 7/7] sdl: add support for top-level parallel make
From:       Maxime Hadjinlian <maxime.hadjinlian () gmail ! com>
Date:       2014-02-14 13:46:55
Message-ID: CAGduivxVTtgVf4sxtqCGXrL4SvZ1f2fdEcxd=aV0QMRYokBUqA () mail ! gmail ! com
[Download RAW message or body]

Hi Fabio, all
On Fri, Feb 14, 2014 at 10:55 AM, Fabio Porcedda
<fabio.porcedda@gmail.com> wrote:
> To be sure that host-autoconf dependency is already built move the
> call to autogen.sh from SDL_POST_PATCH_HOOKS to SDL_PRE_CONFIGURE_HOOKS.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  package/sdl/sdl.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index ba5fbca..cf3366d 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -17,7 +17,7 @@ define SDL_RUN_AUTOGEN
>         cd $(@D) && PATH=$(HOST_PATH) ./autogen.sh
>  endef
>
> -SDL_POST_PATCH_HOOKS += SDL_RUN_AUTOGEN
> +SDL_PRE_CONFIGURE_HOOKS += SDL_RUN_AUTOGEN
>  SDL_DEPENDENCIES += host-automake host-autoconf host-libtool
>
>
> --
> 1.8.5.2
>
I agree with Thomas, it make much more sense in this hook.
I will then resend my patch adding the host variant of sdl.

Acked-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
[prev in list] [next in list] [prev in thread] [next in thread]