[prev in list] [next in list] [prev in thread] [next in thread] 

List:       buildroot
Subject:    Re: [Buildroot] [PATCH v5 4/5] dependencies.sh: XBMC needs java on the host
From:       Maxime Hadjinlian <maxime.hadjinlian () gmail ! com>
Date:       2014-02-14 13:27:35
Message-ID: CAGduivz=G4YY+YDMFHmY_qGzx8Ub2JOa9Zs4SukmvdLq7tfx5g () mail ! gmail ! com
[Download RAW message or body]

On Fri, Feb 14, 2014 at 1:51 PM, Mike Zick <minimod@morethan.org> wrote:
> On Fri, 14 Feb 2014 09:39:30 +0100
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>
>> Dear Maxime Hadjinlian,
>>
>> On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote:
>>
>> > +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then
>> > +   for prog in java; do
>>
>> Since you're checking for only one program, there's no point in having
>> a loop here. Just do:
>>
>>       if ! which java > /dev/null ; then
>>
>
> Wasn't there a patch this development session that replaced
> the use of "which" with a standards compliant command?
You are right, you are talking about:
http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/75049/
But as you can see it was never merged.
Maybe this patch should be bumped again ? It seems there was a problem
with the aliases the user can set but Arnout had an idea about that.
>
> Mike
>>
>> Thanks,
>>
>> Thomas
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
[prev in list] [next in list] [prev in thread] [next in thread]