[prev in list] [next in list] [prev in thread] [next in thread] 

List:       btcd-commits
Subject:    [btcsuite/btcd] 2ceb64: Notify mined transactions before connected block.
From:       Josh Rickmar <jrick () conformal ! com>
Date:       2015-06-18 16:31:00
Message-ID: 5582f244e945d_567b3facdcdd72a065680 () hookshot-fe2-cp1-prd ! iad ! github ! net ! mail
[Download RAW message or body]


  Branch: refs/heads/master
  Home:   https://github.com/btcsuite/btcd
  Commit: 2ceb6418e7ea10d0e17ec6fe53bc78ad1c959680
      https://github.com/btcsuite/btcd/commit/2ceb6418e7ea10d0e17ec6fe53bc78ad1c959680
  Author: Josh Rickmar <jrick@conformal.com>
  Date:   2015-06-17 (Wed, 17 Jun 2015)

  Changed paths:
    M docs/json_rpc_api.md
    M rpcwebsocket.go

  Log Message:
  -----------
  Notify mined transactions before connected block.

This allows clients watching for both to know when all mined
transaction notifications for the block have been received.
Otherwise, clients would be aware that there is a new block, see the
exact same block hash/height in the next tx notifications, but never
know when all txs from the block have been received and processed.

This fixes a synchronization issue in btcwallet where the wallet would
mark itself synced to some block height before any of those blocks'
transactions were processed.  If the RPC connection is lost between
sending the blockconnected notification and receiving the last
transaction notification, the wallet would not know of this and
continue with missing transactions.




[prev in list] [next in list] [prev in thread] [next in thread]