[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bricolage-commits
Subject:    [8374] Fixed problem with rendering of radio button fields (Bug
From:       denny () bricolage ! cc
Date:       2008-11-10 10:19:00
Message-ID: 20081110101901.AB989CB9AF () x12 ! develooper ! com
[Download RAW message or body]

Revision: 8374
Author:   denny
Date:     2008-11-10 02:18:57 -0800 (Mon, 10 Nov 2008)
ViewCVS:  http://viewsvn.bricolage.cc/?rev=8374&view=rev

Log Message:
-----------
Fixed problem with rendering of radio button fields (Bug #1387)

Bugzilla Links:
--------------
    http://bugs.bricolage.cc/show_bug.cgi?id=1387

Modified Paths:
--------------
    bricolage/trunk/comp/widgets/profile/displayFormElement.mc
    bricolage/trunk/lib/Bric/Changes.pod

Modified: bricolage/trunk/comp/widgets/profile/displayFormElement.mc
===================================================================
--- bricolage/trunk/comp/widgets/profile/displayFormElement.mc	2008-11-06 18:43:10 UTC (rev 8373)
+++ bricolage/trunk/comp/widgets/profile/displayFormElement.mc	2008-11-10 10:18:57 UTC (rev 8374)
@@ -211,7 +211,7 @@
         ? ($vals->{props}{class})
         : ();
     push @classes, "textInput" if ($type eq "text" || $type eq "password");
-    push @classes, "required" if ($vals->{req});
+    push @classes, "required" if (ref $vals && $vals->{req});
     my $class = ' class="' . join(" ", @classes) . '"' if scalar @classes;
 
     $extra ||= '';

Modified: bricolage/trunk/lib/Bric/Changes.pod
===================================================================
--- bricolage/trunk/lib/Bric/Changes.pod	2008-11-06 18:43:10 UTC (rev 8373)
+++ bricolage/trunk/lib/Bric/Changes.pod	2008-11-10 10:18:57 UTC (rev 8374)
@@ -20,7 +20,7 @@
 
 =item *
 
-Added the C<is_replublish> and C<is_first_publish> methods to
+Added the C<is_republish> and C<is_first_publish> methods to
 Bric::Util::Burner. [David]
 
 =item *
@@ -58,6 +58,11 @@
 Added confirmation on Delete JavaScript action on Workspace and desk. 
 Reported by Matt Rolf (Bug 1380). [Sarah Mercier]
   
+=item *
+
+Fixed problem with rendering of radio button fields (Bug #1387).  
+[Denny de la Haye]
+
 =back
 
 =head1 VERSION 1.11.1 (2008-10-03)


[Attachment #3 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" /><style \
type="text/css"><!-- #msg dl { border: 1px #006 solid; background: #369; padding: \
6px; color: #fff; } #msg dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer { font-family: \
verdana,arial,helvetica,sans-serif; font-size: 10pt;  } #msg dl a { font-weight: \
bold} #msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: \
bold; } #msg pre { overflow: auto; background: #ffc; border: 1px #fc0 solid; padding: \
6px; } #msg ul, pre { overflow: auto; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: \
6px; } #patch { width: 100%; }
#patch h4 {font-family: \
verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
 #patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, \
#patch .copfile {border:1px solid #ccc;margin:10px 0;} #patch ins \
{background:#dfd;text-decoration:none;display:block;padding:0 10px;} #patch del \
{background:#fdd;text-decoration:none;display:block;padding:0 10px;} #patch .lines, \
                .info {color:#888;background:#fff;}
--></style>
<title>[8374] Fixed problem with rendering of radio button fields (Bug #1387)</title>
</head>
<body>

<div id="msg">
<dl>
<dt>Revision</dt> <dd><a \
href="http://viewsvn.bricolage.cc/?rev=8374&amp;view=rev">8374</a></dd> \
<dt>Author</dt> <dd>denny</dd> <dt>Date</dt> <dd>2008-11-10 02:18:57 -0800 (Mon, 10 \
Nov 2008)</dd> </dl>

<h3>Log Message</h3>
<pre>Fixed problem with rendering of radio button fields (<a \
href="http://bugs.bricolage.cc/show_bug.cgi?id=1387">Bug #1387</a>)</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#bricolagetrunkcompwidgetsprofiledisplayFormElementmc">bricolage/trunk/comp/widgets/profile/displayFormElement.mc</a></li>
 <li><a href="#bricolagetrunklibBricChangespod">bricolage/trunk/lib/Bric/Changes.pod</a></li>
 </ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="bricolagetrunkcompwidgetsprofiledisplayFormElementmc"></a>
<div class="modfile"><h4>Modified: \
bricolage/trunk/comp/widgets/profile/displayFormElement.mc (8373 => 8374)</h4> <pre \
class="diff"><span> <span class="info">--- \
bricolage/trunk/comp/widgets/profile/displayFormElement.mc	2008-11-06 18:43:10 UTC \
                (rev 8373)
+++ bricolage/trunk/comp/widgets/profile/displayFormElement.mc	2008-11-10 10:18:57 \
UTC (rev 8374) </span><span class="lines">@@ -211,7 +211,7 @@
</span><span class="cx">         ? ($vals-&gt;{props}{class})
</span><span class="cx">         : ();
</span><span class="cx">     push @classes, &quot;textInput&quot; if ($type eq \
&quot;text&quot; || $type eq &quot;password&quot;); </span><del>-    push @classes, \
&quot;required&quot; if ($vals-&gt;{req}); </del><ins>+    push @classes, \
&quot;required&quot; if (ref $vals &amp;&amp; $vals-&gt;{req}); </ins><span \
class="cx">     my $class = ' class=&quot;' . join(&quot; &quot;, @classes) . \
'&quot;' if scalar @classes; </span><span class="cx"> 
</span><span class="cx">     $extra ||= '';
</span></span></pre></div>
<a id="bricolagetrunklibBricChangespod"></a>
<div class="modfile"><h4>Modified: bricolage/trunk/lib/Bric/Changes.pod (8373 => \
8374)</h4> <pre class="diff"><span>
<span class="info">--- bricolage/trunk/lib/Bric/Changes.pod	2008-11-06 18:43:10 UTC \
                (rev 8373)
+++ bricolage/trunk/lib/Bric/Changes.pod	2008-11-10 10:18:57 UTC (rev 8374)
</span><span class="lines">@@ -20,7 +20,7 @@
</span><span class="cx"> 
</span><span class="cx"> =item *
</span><span class="cx"> 
</span><del>-Added the C&lt;is_replublish&gt; and C&lt;is_first_publish&gt; methods \
to </del><ins>+Added the C&lt;is_republish&gt; and C&lt;is_first_publish&gt; methods \
to </ins><span class="cx"> Bric::Util::Burner. [David]
</span><span class="cx"> 
</span><span class="cx"> =item *
</span><span class="lines">@@ -58,6 +58,11 @@
</span><span class="cx"> Added confirmation on Delete JavaScript action on Workspace \
and desk.  </span><span class="cx"> Reported by Matt Rolf (Bug 1380). [Sarah Mercier]
</span><span class="cx">   
</span><ins>+=item *
+
+Fixed problem with rendering of radio button fields (Bug #1387).  
+[Denny de la Haye]
+
</ins><span class="cx"> =back
</span><span class="cx"> 
</span><span class="cx"> =head1 VERSION 1.11.1 (2008-10-03)
</span></span></pre>
</div>
</div>

</body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic