[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bricolage-commits
Subject:    [6121] has_keyword was always returning undef!
From:       slanning () bricolage ! cc
Date:       2004-12-28 12:22:34
Message-ID: 20041228122234.18846.qmail () x1 ! develooper ! com
[Download RAW message or body]

Revision: 6121
Author:   slanning
Date:     2004-12-28 04:22:33 -0800 (Tue, 28 Dec 2004)
ViewCVS:  http://viewsvn.bricolage.cc/?rev=6121&view=rev

Log Message:
-----------
has_keyword was always returning undef!

Modified Files:
--------------
    bricolage/branches/rev_1_8/comp/widgets/help/debuggers.html
    bricolage/branches/rev_1_8/lib/Bric/Biz/Asset/Business.pm
    bricolage/branches/rev_1_8/lib/Bric/Changes.pod
    bricolage/branches/rev_1_8/lib/Bric/License.pod



["r6121-slanning.diff" (r6121-slanning.diff)]

Modified: bricolage/branches/rev_1_8/comp/widgets/help/debuggers.html
===================================================================
--- bricolage/branches/rev_1_8/comp/widgets/help/debuggers.html	2004-12-27 18:15:40 UTC (rev 6120)
+++ bricolage/branches/rev_1_8/comp/widgets/help/debuggers.html	2004-12-28 12:22:33 UTC (rev 6121)
@@ -47,4 +47,5 @@
   <li>Clinton Gormley</li>
   <li>Ed Stevenson</li>
   <li>Ashlee Caul</li>
+  <li>Clare Parkinson</li>
 </ul>

Modified: bricolage/branches/rev_1_8/lib/Bric/Biz/Asset/Business.pm
===================================================================
--- bricolage/branches/rev_1_8/lib/Bric/Biz/Asset/Business.pm	2004-12-27 18:15:40 UTC (rev 6120)
+++ bricolage/branches/rev_1_8/lib/Bric/Biz/Asset/Business.pm	2004-12-28 12:22:33 UTC (rev 6121)
@@ -1867,8 +1867,7 @@
 
 sub has_keyword {
     my ($self, $kw) = @_;
-    return unless $self->get_keywords($kw->get_id);
-    return;
+    return scalar($self->get_keywords($kw->get_id)) != 0;
 }
 
 ###############################################################################

Modified: bricolage/branches/rev_1_8/lib/Bric/Changes.pod
===================================================================
--- bricolage/branches/rev_1_8/lib/Bric/Changes.pod	2004-12-27 18:15:40 UTC (rev 6120)
+++ bricolage/branches/rev_1_8/lib/Bric/Changes.pod	2004-12-28 12:22:33 UTC (rev 6121)
@@ -66,6 +66,11 @@
 Added "slug" to the list of attributes specified in the error message for a
 non-unique URI in a story. Thanks to Rachel Murray for the spot! [David]
 
+=item *
+
+Fixed C<has_keyword> for stories and media, which was always returning
+C<undef>. Spotted by Clare Parkinson. [Scott]
+
 =back
 
 =head1 VERSION 1.8.3 (2004-11-09)

Modified: bricolage/branches/rev_1_8/lib/Bric/License.pod
===================================================================
--- bricolage/branches/rev_1_8/lib/Bric/License.pod	2004-12-27 18:15:40 UTC (rev 6120)
+++ bricolage/branches/rev_1_8/lib/Bric/License.pod	2004-12-28 12:22:33 UTC (rev 6121)
@@ -289,6 +289,8 @@
 
 =item Ashlee Caul
 
+=item Clare Parkinson
+
 =back
 
 Bricolage's translation team:


[prev in list] [next in list] [prev in thread] [next in thread]