[prev in list] [next in list] [prev in thread] [next in thread]
List: bricolage-commits
Subject: [Bricolage-Commits] Removed all the instances of Data::Dumper I could find.
From: David Wheeler <wheeler () users ! sourceforge ! net>
Date: 2002-08-30 17:05:27
[Download RAW message or body]
Log Message:
-----------
Removed all the instances of Data::Dumper I could find. I left those that are
specifically for testing or somesuch, as in the installer scripts, the SOAP
classes, and the debugging Mason component used to add information to every
screen in QA_MODE. It shouldn't be getting loaded anymore, but it still is. I
think it must be one of the modules we're using that's loading it now. Bummer.
Modified Files:
--------------
/cvsroot/bricolage/bricolage/comp/widgets/admin_container_profile:
callback.mc
/cvsroot/bricolage/bricolage/comp/widgets/admin_container_type_profile:
callback.mc
/cvsroot/bricolage/bricolage/comp/widgets/element:
callback.mc
element.mc
/cvsroot/bricolage/bricolage/lib/Bric/Biz/Asset/Business:
Story.pl
/cvsroot/bricolage/bricolage/lib/Bric/Util/Burner:
Template.pm
["wheeler-200283017527-diff.txt" (wheeler-200283017527-diff.txt)]
Index: callback.mc
===================================================================
RCS file: /cvsroot/bricolage/bricolage/comp/widgets/admin_container_profile/callback.mc,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -w -d -r1.1.1.1 -r1.2
--- callback.mc 6 Sep 2001 21:51:59 -0000 1.1.1.1
+++ callback.mc 30 Aug 2002 17:05:24 -0000 1.2
@@ -6,9 +6,6 @@
<%perl>
-print STDERR "Handling field $field.\n";
-#print STDERR "ARGS = ", Data::Dumper::Dumper(\%ARGS), "\n\n";
-
my ($section, $mode, $type) = $m->comp("/lib/util/parseUri.mc");
# What class is this object?
@@ -20,7 +17,6 @@
$obj = $class->lookup({ id => $param->{id} })
} else {
$obj = get_state_data('admin_container_profile', 'cur_obj');
- print STDERR "obj = ", Data::Dumper::Dumper(\$obj), "\n\n";
if (!$obj) {
$obj = $class->new();
}
@@ -31,29 +27,21 @@
# create new data object on current asset type
# set data object name = name field from form builder
-
- print STDERR "Saving or modifying attribute ... \n";
-
my $dataObj = $obj->get_data( $param->{name} );
if (!$dataObj) {
- print STDERR "new data\n";
$dataObj = $obj->new_data({ name => $param->{name} });
} else {
- print STDERR "modifying existing data point";
#$obj->del_data( $dataObj );
#$dataObj = $obj->new_data({ name => $param->{name} });
}
# add new attr to data object
$dataObj->set_attr($param->{name}, $param->{name});
- print STDERR "done setting attr as $param->{name} \n";
- print STDERR "$widget:$field \n";
# set meta data on the html_info attribute
foreach my $k (keys %$param) {
next if ($k eq 'name' || $k eq $field) ;
$dataObj->set_meta( $param->{name}, $k, $param->{$k} );
- print STDERR "new meta key: $k value: " . $param->{$k} . "\n";
}
}
@@ -62,7 +50,6 @@
if ($field eq "$widget:add_attr_cb" || $field eq "$widget:save_cb") {
# save name and description
- print STDERR "$field ... saving... name and description\n";
$obj->set_name($param->{name});
$obj->set_description($param->{description});
# TODO: save mods to any data fields
@@ -74,7 +61,6 @@
# now that that's over, set the id
$param->{id} = $obj->get_id;
-print STDERR $obj->get_attr($param->{name});
# set widget state
if ($field eq "$widget:save_cb" ) { # save returns to manager, so clear the profile \
state $obj->activate;
Index: callback.mc
===================================================================
RCS file: /cvsroot/bricolage/bricolage/comp/widgets/admin_container_type_profile/callback.mc,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -w -d -r1.1.1.1 -r1.2
--- callback.mc 6 Sep 2001 21:51:59 -0000 1.1.1.1
+++ callback.mc 30 Aug 2002 17:05:24 -0000 1.2
@@ -6,9 +6,6 @@
<%perl>
-print STDERR "Handling field $field.\n";
-print STDERR "ARGS = ", Data::Dumper::Dumper($param), "\n\n";
-
my ($section, $mode, $type) = $m->comp("/lib/util/parseUri.mc");
# What class is this object?
@@ -22,31 +19,19 @@
$obj = $class->new();
}
-print STDERR "got object...\n\n";
-
if ( $field eq "$widget:save_and_exit_cb" || $field eq "$widget:save_and_return_cb" \
) {
# save name and description
- print STDERR "$field ... saving... name and description\n";
-
$obj->set_name($param->{name}) if ($param->{name});
$obj->set_description( $param->{description} ) if ($param->{description});
-
- print STDERR "$field ... saving... toplevel and paginated...\n\n";
-
$obj->set_top_level( ($param->{top_level}) ? 1 : 0);
$obj->set_paginated( ($param->{paginated}) ? 1 : 0);
-
($param->{delete}) ? $obj->deactivate : $obj->activate;
-
$obj->save;
-
$param->{id} = $obj->get_id;
-
if ($field eq "$widget:save_and_exit_cb") {
set_redirect('/admin/manager/container_type');
}
}
-
</%perl>
Index: callback.mc
===================================================================
RCS file: /cvsroot/bricolage/bricolage/comp/widgets/element/callback.mc,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -w -d -r1.5 -r1.6
--- callback.mc 4 Dec 2001 18:17:40 -0000 1.5
+++ callback.mc 30 Aug 2002 17:05:24 -0000 1.6
@@ -42,9 +42,6 @@
=head1 SYNOPSIS
-print STDERR Data::Dumper::Dumper($param);
-return;
-
$m->comp('/widgets/formBuilder/callback.mc', %ARGS);
=head1 DESCRIPTION
Index: element.mc
===================================================================
RCS file: /cvsroot/bricolage/bricolage/comp/widgets/element/element.mc,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -w -d -r1.5 -r1.6
--- element.mc 4 Dec 2001 18:17:40 -0000 1.5
+++ element.mc 30 Aug 2002 17:05:24 -0000 1.6
@@ -23,23 +23,22 @@
<%perl>;
-return unless $field eq "$widget|addElement_cb" || $field eq \
"$widget|doRedirect_cb"; +return unless $field eq "$widget|addElement_cb" ||
+ $field eq "$widget|doRedirect_cb";
my $comp = $obj;
# switch on $field
if ($field eq "$widget|addElement_cb") {
- my @elements = (ref $param->{"$widget|addElement_cb"} eq "ARRAY" ) ? \
$param->{"$widget|addElement_cb"} : [ $param->{"$widget|addElement_cb"} ]; + my \
@elements = (ref $param->{"$widget|addElement_cb"} eq "ARRAY" ) + ? \
$param->{"$widget|addElement_cb"} + : [ $param->{"$widget|addElement_cb"} ];
# add element to object using id(s)
$comp->add_containers( @elements );
$comp->save;
-# print STDERR Data::Dumper::Dumper($comp);
-
} elsif ($field eq "$widget|doRedirect_cb") {
-
set_redirect('/admin/profile/element/'. $param->{element_id} );
-
}
return $comp;
Index: Story.pl
===================================================================
RCS file: /cvsroot/bricolage/bricolage/lib/Bric/Biz/Asset/Business/Story.pl,v
retrieving revision 1.1.1.1
retrieving revision 1.2
diff -u -w -d -r1.1.1.1 -r1.2
--- Story.pl 6 Sep 2001 21:53:47 -0000 1.1.1.1
+++ Story.pl 30 Aug 2002 17:05:25 -0000 1.2
@@ -38,9 +38,8 @@
$story->save();
};
-if ($@) {
- die Data::Dumper::Dumper($@);
-}
+
+die $@ if $@;
print "Checked out story is " . $story->get_id() . "\n";
Index: Template.pm
===================================================================
RCS file: /cvsroot/bricolage/bricolage/lib/Bric/Util/Burner/Template.pm,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -w -d -r1.19 -r1.20
--- Template.pm 5 Aug 2002 19:34:41 -0000 1.19
+++ Template.pm 30 Aug 2002 17:05:25 -0000 1.20
@@ -57,7 +57,6 @@
use Bric::Util::Fault::Exception::MNI;
use Bric::Dist::Resource;
use Bric::Config qw(:burn);
-use Data::Dumper;
use Digest::MD5 qw(md5 md5_hex);
use Time::HiRes qw(time);
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
_______________________________________________
Bricolage-Commits mailing list
Bricolage-Commits@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bricolage-commits
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic