[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bricolage-bugs
Subject:    [Bug 1331] Checkin and Publish Animations Ignore Errors
From:       bugs () lists ! bricolage ! cc
Date:       2008-09-29 16:51:17
Message-ID: 20080929165117.8F96DD3362 () mail ! exclupen ! com
[Download RAW message or body]

http://bugs.bricolage.cc/show_bug.cgi?id=1331


David Wheeler <david@kineticode.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #6 from David Wheeler <david@kineticode.com>  2008-09-29 12:51:16 ---
(In reply to comment #5)

> Okay, I've got the architecture for this in place as of r8286. I'll do an audit
> of all calls to `add_msg()` in callbacks next week and update them as
> appropriate.

And now that's done, as of r8287. Callbacks now can call `add_message()` for
status messages ("Foo has been saved."), `raise_forbidden()` for permission
issues ("You do not have permission to edit foo."), or `raise_conflict()` for
entity state issues ("Name is required."). The JavaScript requests now properly
handle the forbidden and conflict errors, throwing up a lightbox when they come
in and not triggering any animations, as well as 500 errors. Messages passed to
`add_message()` during an Ajax request will be displayed as usual in the next
request; we should weed these out as we see them, as appropriate.

Anyway, with that, the issues here are resolved, and I'm closing this bug
report.


-- 
Configure bugmail: http://bugs.bricolage.cc/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]