[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bochs-dev
Subject:    Re: [Bochs-developers] [PATCH] Pack new ACPI structures
From:       "Stanislav" <stlintel () gmail ! com>
Date:       2008-12-27 16:32:35
Message-ID: 000901c96840$bb0173c0$31045b40$ () com
[Download RAW message or body]

Sebastian, could you explain in few words what is the HPET structure and
what it defines ?
What is required to be implemented in Bochs in order to support it (and
remove ifdefs) ?

Thanks,
Stanislav

-----Original Message-----
From: Sebastian Herbszt [mailto:herbszt@gmx.de] 
Sent: Saturday, December 27, 2008 5:45 PM
To: bochs-developers
Subject: [Bochs-developers] [PATCH] Pack new ACPI structures

The HPET merge from QEMU introduced new structures which need packing.

- Sebastian

--- bochs-20081227/bios/rombios32.c.orig 2008-12-27 16:30:08.000000000 +0100
+++ bochs-20081227/bios/rombios32.c 2008-12-27 16:35:06.000000000 +0100
@@ -1294,7 +1294,7 @@ struct acpi_20_generic_address {
     uint8_t  register_bit_offset;
     uint8_t  reserved;
     uint64_t address;
-};
+} __attribute__((__packed__));
 
 /*
  *  * HPET Description Table
@@ -1306,7 +1306,7 @@ struct acpi_20_hpet {
     uint8_t            hpet_number;
     uint16_t           min_tick;
     uint8_t            page_protect;
-};
+} __attribute__((__packed__));
 #define ACPI_HPET_ADDRESS 0xFED00000UL
 #endif
 
@@ -1328,7 +1328,7 @@ struct madt_int_override
  uint8_t                source;  /* Bus-relative interrupt source */
  uint32_t               gsi;     /* GSI that source will signal */
  uint16_t               flags;   /* MPS INTI flags */
-};
+} __attribute__((__packed__));
 #endif
 
 #include "acpi-dsdt.hex"


------------------------------------------------------------------------------
_______________________________________________
bochs-developers mailing list
bochs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bochs-developers
[prev in list] [next in list] [prev in thread] [next in thread]