[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bochs-dev
Subject:    Re: [Bochs-developers] Minor "save config" bugfix
From:       "Stanislav" <stl () fidonet ! org ! il>
Date:       2007-12-06 22:20:16
Message-ID: 001d01c83856$2db15b40$6402a8c0 () gatebc117ccee2
[Download RAW message or body]

Thanks, fixed !

Stanislav

> -----Original Message-----
> From: bochs-developers-bounces@lists.sourceforge.net [mailto:bochs-
> developers-bounces@lists.sourceforge.net] On Behalf Of Brendan Trotter
> Sent: Thursday, December 06, 2007 11:53 PM
> To: bochs-developers@lists.sourceforge.net
> Subject: [Bochs-developers] Minor "save config" bugfix
> 
> Hi,
> 
> In the file "config.cc" (taken from CVS today) there's a missing
> newline character that makes it impossible for Bochs to reload a
> previously saved configuration in some situations. For me, Bochs
> generates the line:
> 
> cmosimage: file=cmos.img, rtc_init=time0ne2k: enabled=0
> 
> 
> The original code (from around line 3282 in "config.cc") goes like this:
> 
> ----8<----
> 
>   if (strlen(SIM->get_param_string(BXPN_CMOSIMAGE_PATH)->getptr()) > 0) {
>     fprintf(fp, "cmosimage: file=%s, ",
> SIM->get_param_string(BXPN_CMOSIMAGE_PATH)->getptr());
>     fprintf(fp, "rtc_init=%s",
> SIM->get_param_bool(BXPN_CMOSIMAGE_RTC_INIT)->get()?"image":"time0");
>   } else {
>     fprintf(fp, "# no cmosimage\n");
>   }
> 
> ----8<----
> 
> The corrected code would go like this:
> 
> ----8<----
> 
>   if (strlen(SIM->get_param_string(BXPN_CMOSIMAGE_PATH)->getptr()) > 0) {
>     fprintf(fp, "cmosimage: file=%s, ",
> SIM->get_param_string(BXPN_CMOSIMAGE_PATH)->getptr());
>     fprintf(fp, "rtc_init=%s\n",
> SIM->get_param_bool(BXPN_CMOSIMAGE_RTC_INIT)->get()?"image":"time0");
>   } else {
>     fprintf(fp, "# no cmosimage\n");
>   }
> 
> ----8<----
> 
> Hope that helps..
> 
> 
> Cheers,
> 
> Brendan
> 
> -------------------------------------------------------------------------
> SF.Net email is sponsored by:
> Check out the new SourceForge.net Marketplace.
> It's the best place to buy or sell services for
> just about anything Open Source.
> http://sourceforge.net/services/buy/index.php
> _______________________________________________
> bochs-developers mailing list
> bochs-developers@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bochs-developers



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
bochs-developers mailing list
bochs-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bochs-developers
[prev in list] [next in list] [prev in thread] [next in thread]