[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bochs-cvs
Subject:    [Bochs-cvs] CVS: bochs/cpu paging.cc, 1.81, 1.82 protect_ctrl.cc,
From:       Stanislav Shwartsman <sshwarts () users ! sourceforge ! net>
Date:       2007-03-23 14:50:48
Message-ID: E1HUl6O-0001Xr-87 () sc8-pr-cvs3 ! sourceforge ! net
[Download RAW message or body]

Update of /cvsroot/bochs/bochs/cpu
In directory sc8-pr-cvs3.sourceforge.net:/tmp/cvs-serv5573/cpu

Modified Files:
	paging.cc protect_ctrl.cc 
Log Message:
Removed redundant mem-only checks - handled in fetchdecode now


Index: paging.cc
===================================================================
RCS file: /cvsroot/bochs/bochs/cpu/paging.cc,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -d -r1.81 -r1.82
--- paging.cc	13 Jan 2007 10:43:31 -0000	1.81
+++ paging.cc	23 Mar 2007 14:50:45 -0000	1.82
@@ -552,11 +552,6 @@
 #if BX_CPU_LEVEL >= 4
   invalidate_prefetch_q();
 
-  if (i->modC0()) {
-    BX_INFO(("INVLPG: op is a register"));
-    UndefinedOpcode(i);
-  }
-
   if (!real_mode() && CPL!=0) {
     BX_ERROR(("INVLPG: priveledge check failed, generate #GP(0)"));
     exception(BX_GP_EXCEPTION, 0, 0);

Index: protect_ctrl.cc
===================================================================
RCS file: /cvsroot/bochs/bochs/cpu/protect_ctrl.cc,v
retrieving revision 1.57
retrieving revision 1.58
diff -u -d -r1.57 -r1.58
--- protect_ctrl.cc	14 Mar 2007 21:15:15 -0000	1.57
+++ protect_ctrl.cc	23 Mar 2007 14:50:45 -0000	1.58
@@ -631,12 +631,6 @@
 
 void BX_CPU_C::SGDT_Ms(bxInstruction_c *i)
 {
-  /* op1 is a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("SGDT_Ms: use of register is undefined opcode"));
-    UndefinedOpcode(i);
-  }
-
   Bit16u limit_16 = BX_CPU_THIS_PTR gdtr.limit;
   Bit32u base_32  = BX_CPU_THIS_PTR gdtr.base;
 
@@ -646,12 +640,6 @@
 
 void BX_CPU_C::SIDT_Ms(bxInstruction_c *i)
 {
-  /* op1 is a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("SIDT_Ms: use of register is undefined opcode"));
-    UndefinedOpcode(i);
-  }
-
   Bit16u limit_16 = BX_CPU_THIS_PTR idtr.limit;
   Bit32u base_32  = BX_CPU_THIS_PTR idtr.base;
 
@@ -661,12 +649,6 @@
 
 void BX_CPU_C::LGDT_Ms(bxInstruction_c *i)
 {
-  /* operand might be a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("LGDT: must be memory reference"));
-    UndefinedOpcode(i);
-  }
-
   if (v8086_mode()) {
     BX_ERROR(("LGDT: not recognized in virtual-8086 mode"));
     exception(BX_GP_EXCEPTION, 0, 0);
@@ -708,12 +690,6 @@
 
 void BX_CPU_C::LIDT_Ms(bxInstruction_c *i)
 {
-  /* operand might be a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("LIDT: must be memory reference"));
-    UndefinedOpcode(i);
-  }
-
   if (v8086_mode()) {
     BX_ERROR(("LIDT: not recognized in virtual-8086 mode"));
     exception(BX_GP_EXCEPTION, 0, 0);
@@ -752,12 +728,6 @@
 
 void BX_CPU_C::SGDT64_Ms(bxInstruction_c *i)
 {
-  /* op1 is a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("SGDT64_Ms: use of register is undefined opcode"));
-    UndefinedOpcode(i);
-  }
-
   Bit16u limit_16 = BX_CPU_THIS_PTR gdtr.limit;
   Bit64u base_64  = BX_CPU_THIS_PTR gdtr.base;
 
@@ -767,12 +737,6 @@
 
 void BX_CPU_C::SIDT64_Ms(bxInstruction_c *i)
 {
-  /* op1 is a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("SIDT64_Ms: use of register is undefined opcode"));
-    UndefinedOpcode(i);
-  }
-
   Bit16u limit_16 = BX_CPU_THIS_PTR idtr.limit;
   Bit64u base_64  = BX_CPU_THIS_PTR idtr.base;
 
@@ -811,12 +775,6 @@
 {
   BX_ASSERT(protected_mode());
 
-  /* operand might be a register or memory reference */
-  if (i->modC0()) {
-    BX_ERROR(("LIDT64_Ms: must be memory reference"));
-    UndefinedOpcode(i);
-  }
-
   if (CPL != 0) {
     BX_ERROR(("LIDT64_Ms: CPL != 0 in long mode"));
     exception(BX_GP_EXCEPTION, 0, 0);


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bochs-cvs mailing list
Bochs-cvs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bochs-cvs
[prev in list] [next in list] [prev in thread] [next in thread]