[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bitkeeper-users
Subject:    Re: [Bitkeeper-users] [BK] cset -x improvement (prototype)
From:       Tom Rini <trini () kernel ! crashing ! org>
Date:       2003-12-31 17:46:03
Message-ID: 20031231174603.GG1007 () stop ! crashing ! org
[Download RAW message or body]

On Wed, Dec 31, 2003 at 10:33:36AM -0700, Bjorn Helgaas wrote:
> On Tuesday 30 December 2003 6:49 pm, Larry McVoy wrote:
> > The documented behaviour of cset -x is that it only undoes content
> > changes, not renames, creates, permissions, etc.  This interface is
> > unique in that respect, all the other interfaces in BK operate on all
> > attributes, not just contents.
> > 
> > I've prototyped a version of the interface which works on contents,
> > names, and permissions, and in addition also uses the BK merge tools to
> > merge any conflicting changes as a result of the undo of the changeset.
> > This is JUST A PROTOTYPE and has a lot of limitations but I'd like some
> > feedback on whether this is a good direction and we should productize
> > this or if this is not helpful to you.
> 
> I use "cset -x" only occasionally, but I think this is a good direction.
> 
> As a consumer of trees where others use "cset -x", I find the comments
> only marginally useful.  For example, Marcelo just reverted a couple
> changesets in linux-2.4.  From my "bkexport" script, I can see that
> the comments added by "cset -x" are:
> 
>     ### Comments for ChangeSet
>     Cset exclude: marcelo@logos.cnet|ChangeSet|20031231111415|59075
>     ### Comments for fs/inode.c
>     Exclude
>     ### Comments for mm/filemap.c
>     Exclude
> 
> "bk changes" and "prs" would be more useful if the "cset -x" comments
> included some reference to the original, i.e.:

Or if it forced you to do comments, as opposed to making them optional
as they are now.

-- 
Tom Rini
http://gate.crashing.org/~trini/

_______________________________________________
Bitkeeper-users mailing list
Bitkeeper-users@bitmover.com
http://bitmover.com/mailman/listinfo/bitkeeper-users
To unsubscribe from this list, go to the above URL, follow instruction at the bottom of the web page.
[prev in list] [next in list] [prev in thread] [next in thread]