[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bird-users
Subject:    Re: Multiple ebgp neighbours to the same peer
From:       Alexander Zubkov via Bird-users <bird-users () network ! cz>
Date:       2023-01-24 7:22:42
Message-ID: CABr+u0ZJX8Er3s-3t4WfvwBOfq=tDArBm33vV1F02jg6XWpTYg () mail ! gmail ! com
[Download RAW message or body]

On Mon, Jan 23, 2023 at 3:17 PM Alexander Zubkov <green@qrator.net> wrote:

>
>
> On Mon, Jan 23, 2023 at 3:06 PM Ondrej Zajicek <santiago@crfreenet.org>
> wrote:
>
>> On Mon, Jan 23, 2023 at 12:40:30AM +0100, Alexander Zubkov wrote:
>> > Hi all,
>> >
>> > A quick try to fix the problem. But I'm not sure in complete correctness
>> > though.
>>
>> Hi
>>
>> That looks more-or-less OK, will merge.
>>
>> > -    ipa_equal(x->addr, y->addr);
>> > +    ipa_equal(x->addr, y->addr) &&
>> > +    ipa_equal(x->addr2, y->addr2);
>>
>> I think undefined addr2 should work like wildcard, i.e. the condition
>> should be:
>>
>>
> Maybe. I do not know well how this lock works. If different lock keys can
> affect another. And in this case it is probably better to fix "local" role
> for that second address and reflect it in its name.
>

I think even better to call this wildcard_addr, for example. So if
something else needs this wildcard feature, it is clear which addr to use
in the lock object.


>
>
>>  ipa_equal(x->addr, y->addr) &&
>>  (ipa_zero(x->addr2) || ipa_zero(y->addr2) || ipa_equal(x->addr2,
>> y->addr2));
>>
>> (Undefined local ip will be resolved to some ip and may collide with
>> defined ones.)
>>
>> --
>> Elen sila lumenn' omentielvo
>>
>> Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org)
>> OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
>> "To err is human -- to blame it on a computer is even more so."
>>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Mon, Jan 23, 2023 at 3:17 PM Alexander Zubkov &lt;<a \
href="mailto:green@qrator.net">green@qrator.net</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 23, 2023 at 3:06 PM \
Ondrej Zajicek &lt;<a href="mailto:santiago@crfreenet.org" \
target="_blank">santiago@crfreenet.org</a>&gt; wrote:<br></div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">On Mon, Jan 23, 2023 at 12:40:30AM +0100, \
Alexander Zubkov wrote:<br> &gt; Hi all,<br>
&gt; <br>
&gt; A quick try to fix the problem. But I&#39;m not sure in complete correctness<br>
&gt; though.<br>
<br>
Hi<br>
<br>
That looks more-or-less OK, will merge.<br>
<br>
&gt; -      ipa_equal(x-&gt;addr, y-&gt;addr);<br>
&gt; +      ipa_equal(x-&gt;addr, y-&gt;addr) &amp;&amp;<br>
&gt; +      ipa_equal(x-&gt;addr2, y-&gt;addr2);<br>
<br>
I think undefined addr2 should work like wildcard, i.e. the condition should be:<br>
<br></blockquote><div><br></div><div>Maybe. I do not know well how this lock works. \
If different lock keys can affect another. And in this case it is probably better to \
fix &quot;local&quot; role for that second address and reflect it in its \
name.<br></div></div></div></blockquote><div><br></div><div>I think even better to \
call this wildcard_addr, for example. So if something else needs this wildcard \
feature, it is clear which addr to use in the lock object.<br></div><div>  \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px \
solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div \
class="gmail_quote"><div></div><div>  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">  ipa_equal(x-&gt;addr, y-&gt;addr) &amp;&amp;<br>
  (ipa_zero(x-&gt;addr2) || ipa_zero(y-&gt;addr2) || ipa_equal(x-&gt;addr2, \
y-&gt;addr2));<br> <br>
(Undefined local ip will be resolved to some ip and may collide with<br>
defined ones.)<br>
<br>
-- <br>
Elen sila lumenn&#39; omentielvo<br>
<br>
Ondrej &#39;Santiago&#39; Zajicek (email: <a href="mailto:santiago@crfreenet.org" \
target="_blank">santiago@crfreenet.org</a>)<br> OpenPGP encrypted e-mails preferred \
(KeyID 0x11DEADC3, <a href="http://wwwkeys.pgp.net" rel="noreferrer" \
target="_blank">wwwkeys.pgp.net</a>)<br> &quot;To err is human -- to blame it on a \
computer is even more so.&quot;<br> </blockquote></div></div>
</blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]