[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bird-users
Subject:    Re: [PATCH] babel: Set onlink flag for IPv4 routes with unreachable next hop
From:       Andreas Rammhold <andreas () rammhold ! de>
Date:       2020-04-14 8:42:36
Message-ID: 20200414084236.5sxdgef7sjj5vkxq () wrt
[Download RAW message or body]

On 15:30 09.05.18, Toke Høiland-Jørgensen wrote:
> Ondrej Zajicek <santiago@crfreenet.org> writes:
> > There are some minor issues (like there should be check for error values
> > from neigh_find2()), but that can i fix. I just wonder whether we would
> > want this behavior as a default or whether it should be configurable.
> > What do you think?
> 
> Well, always-on matches what babeld does, that's why I went with that.
> Is there a case where this is not desirable behaviour?

I would also like to see this get accepted into bird. I've been using
the patch that Toke proposed (and thats available on [OpenWRT's tree])
without issues.

From my perspective there is no need to make this configurable. It is
indeed what I would expect as default.

Is there anything besides the error handling that should be changed?

The linked patchset is also rebased. I am happy to resubmit it, if
needed.


Regards,

Andi

[OpenWRT's tree]: https://github.com/openwrt-routing/packages/blob/37f8c509e03de355a3d \
0f9b6d62837c43750f98b/bird2/patches/0001-babel-Set-onlink-flag-for-IPv4-routes-with-unreachab.patch



[prev in list] [next in list] [prev in thread] [next in thread]