[prev in list] [next in list] [prev in thread] [next in thread] 

List:       bioc-devel
Subject:    Re: [Bioc-devel] Failing GenVisR package
From:       "Obenchain, Valerie" <Valerie.Obenchain () RoswellPark ! org>
Date:       2018-10-23 21:23:21
Message-ID: BY2PR12MB00084CBFDE30720DDD60E336FFF50 () BY2PR12MB0008 ! namprd12 ! prod ! outlook ! com
[Download RAW message or body]

Hi Zach,

You should not have to add skip_on_bioc().

Confirming system dependencies, the vdiffr package requires FreeType >= 2.6.0 and the \
Bioconductor 3.8 builder has version 2.6.1. Do you know which font libraries are \
used?

Did you start seeing these failures around the time of this commit or was that a \
separate issue?

commit 77866fb2b8d137ce38ea0d47b327fc379c4416e9 (HEAD -> master, origin/master, \
                origin/HEAD)
Author: Zach Skidmore <zskidmor@genome.wustl.edu><mailto:zskidmor@genome.wustl.edu>
Date:   Thu Oct 11 16:37:33 2018 -0500

    fixed failing test case in lolliplot caused by interpro domains changing


Valerie

On 10/22/18 9:51 AM, Skidmore, Zach wrote:

Hi All,

I'm looking for some advice, I maintain the GenVisR package, it is currently failing \
on malbec1-devel. I use the vdiffr package to perform visual test cases, essentially \
the package compares the SVG output to a predefined expectation and fails if an \
anomaly is detected. This worked perfectly until perhaps a month ago, given that the \
visual test-case fails only on malbec1 I suspect the issue is something small, \
perhaps malbec1 uses a different font library causing the SVG's to be significantly \
different.

At any rate I'm looking for any advice on how to:

1) determine what the difference is, normally I would run vdiffr::manage_cases() but \
obviously that is not possible with the automated build system. Is there a docker \
image available that corresponds exactly to malbec1?

2) Again I suspect that this is a minor issue given that everything is fine on the \
other two OS, but I'm trying to figure out the proper course of action to resolve \
this. I could add a skip_on_bioc() flag for all visual test-cases. I would rather not \
do that if there is a way to avoid it though.

Thanks for any advice!
Zach

________________________________
The materials in this message are private and may contain Protected Healthcare \
Information or other information of a sensitive nature. If you are not the intended \
recipient, be advised that any unauthorized use, disclosure, copying or the taking of \
any action in reliance on the contents of this information is strictly prohibited. If \
you have received this email in error, please immediately notify the sender via \
telephone or return mail.

        [[alternative HTML version deleted]]

_______________________________________________
Bioc-devel@r-project.org<mailto:Bioc-devel@r-project.org> mailing list
https://stat.ethz.ch/mailman/listinfo/bioc-devel





This email message may contain legally privileged and/or confidential information.  \
If you are not the intended recipient(s), or the employee or agent responsible for \
the delivery of this message to the intended recipient(s), you are hereby notified \
that any disclosure, copying, distribution, or use of this email message is \
prohibited.  If you have received this message in error, please notify the sender \
immediately by e-mail and delete this email message from your computer. Thank you.  \
[[alternative HTML version deleted]]

_______________________________________________
Bioc-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/bioc-devel


[prev in list] [next in list] [prev in thread] [next in thread]