[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: [PATCH v6] MIPS: Reject branch absolute relocs for PIC for linking
From:       YunQiang Su <syq () gcc ! gnu ! org>
Date:       2024-02-22 6:29:50
Message-ID: CAKcpw6W0S0JshQamEkx1pJuVzSwSZ9UMb1M3oNsiiHWcZVO77Q () mail ! gmail ! com
[Download RAW message or body]

> > +               howto = MIPS_ELF_RTYPE_TO_HOWTO (abfd, r_type, NEWABI_P (abfd));
> > +               info->callbacks->einfo
> > +                 /* xgettext:c-format */
> > +                 (_("%X%H: relocation %s against `*ABS*' cannot be used"
>
> There's no "*ABS*" in the source and IMHO that'd look confusing
> to innocent users.  How about "...against an absolute value"?
> Or "...against an absolute value or absolute symbol"?  Perhaps
> the latter is a bit too wordy, but also more complete.
>

Good idea. I think that we should use "...against an absolute value".
"absolute symbol"  is not included in this code, as it's r_symndx is
not STN_UNDEF.
An example is gas/testsuite/gas/mips/branch-absolute.s.

Thank you,
[prev in list] [next in list] [prev in thread] [next in thread]