[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: [PATCH] Fix a double free in objcopy.
From:       Nick Clifton via Binutils <binutils () sourceware ! org>
Date:       2021-01-27 10:34:51
Message-ID: 24d49650-1c0f-d602-aa03-872fbdf63c75 () redhat ! com
[Download RAW message or body]

Hi Alan,

>>> 	* objcopy.c (copy_main): Fix a double free happening when both
>>> 	--localize-symbols and --globalize-symbols options are invoked
>>> 	together.

> I put this on the 2.36 and 2.35 branches too, along with c3ffb8f340
> "Segmentation fault i386-gen" on the grounds these patches are zero
> risk.  I also put 4287950e54 "pr27228 testcase" on 2.36 to fix the
> testcase that was applied there.

Thanks very much.

It occurred to me after applying the patch to objcopy.c that we do
not need the conditional part of the "if (<name>) free (<name>)"
statements, and that if they had been removed then the double free
might have been more obvious.  I will update mainline, but I do not
see any particular need to backport this particular change.

Cheers
   Nick




[prev in list] [next in list] [prev in thread] [next in thread]