[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    gas output_file_close error message
From:       Alan Modra via Binutils <binutils () sourceware ! org>
Date:       2020-11-25 12:16:43
Message-ID: 20201125120443.GM12697 () bubble ! grove ! modra ! org
[Download RAW message or body]

Seen on arm-elf, where ELFOSABI_ARM is set too late to get a warning
when processing ifunc related directives on their source line.
../gas/as-new ifunc.s -o tmpdir/ifunc.o
../gas/as-new: symbol type STT_GNU_IFUNC is supported only by GNU and FreeBSD targets
ifunc.s: Assembler messages:
ifunc.s: Fatal error: can't close tmpdir/ifunc.o: sorry, cannot handle this file

This patch doesn't fix the real underlying problem, just the late
error message where "can't close" is a misdirection in this case.

	* output-file.c (output_file_close): Remove "can't close" from
	error message.
	* testsuite/gas/mips/reginfo-2.l: Update expected output.

diff --git a/gas/output-file.c b/gas/output-file.c
index 573598101c..b8d2132277 100644
--- a/gas/output-file.c
+++ b/gas/output-file.c
@@ -68,6 +68,5 @@ output_file_close (const char *filename)
   stdoutput = NULL;
 
   if (! res)
-    as_fatal (_("can't close %s: %s"), filename,
-	      bfd_errmsg (bfd_get_error ()));
+    as_fatal ("%s: %s", filename, bfd_errmsg (bfd_get_error ()));
 }
diff --git a/gas/testsuite/gas/mips/reginfo-2.l b/gas/testsuite/gas/mips/reginfo-2.l
index fd3efa93a2..3d171f2c09 100644
--- a/gas/testsuite/gas/mips/reginfo-2.l
+++ b/gas/testsuite/gas/mips/reginfo-2.l
@@ -1,3 +1,3 @@
 .*: incorrect `\.reginfo' section size; expected 24, got 28
 .*: Assembler messages:
-.*: Fatal error: can't close .*: bad value
+.*: Fatal error: .*: bad value

-- 
Alan Modra
Australia Development Lab, IBM
[prev in list] [next in list] [prev in thread] [next in thread]