[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: [PATCH] Introduce new .text.sorted.* sections.
From:       Alan Modra <amodra () gmail ! com>
Date:       2019-09-27 7:49:13
Message-ID: 20190927074857.GC15102 () bubble ! grove ! modra ! org
[Download RAW message or body]

On Thu, Sep 26, 2019 at 10:48:12AM +0200, Martin Liška wrote:
> On 9/25/19 3:34 PM, Alan Modra wrote:
> > On Tue, Sep 24, 2019 at 02:05:09PM +0200, Martin Liška wrote:
> >> Hi.
> >>
> >> Aim of the patch is to introduce a new .text subsection that
> >> will be sorted by default. That can be leveraged in LTO where we
> >> want to provide a specific sorting of symbols in a binary.
> > 
> > This looks fine to me, even though the gold implementation can produce
> > different results on input sections that match ".text.sorted.*".  For
> > example, ".text.sorted.1" will be accepted by both ld.gold and ld.bfd,
> > but ld.bfd will sort it after ".text.sorted.02" while ld.gold would
> > sort it before.
> 
> Hi.
> 
> You are right, it's not precisely 1:1 among ld.bfd and ld.gold. I guess
> we can live with that.
> 
> May I take this as an approval to install the patch?

I can OK the ld.bfd changes, I'm not so sure about gold patches.  Cary
and Ian are the ones with that authority.

-- 
Alan Modra
Australia Development Lab, IBM
[prev in list] [next in list] [prev in thread] [next in thread]