[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: [PATCH]: XCOFF : Ensure .text/.data file offset == vma % pagesize
From:       Richard Sandiford <rsandifo () linux ! vnet ! ibm ! com>
Date:       2013-07-30 14:39:41
Message-ID: 87li4oaz82.fsf () sandifor-thinkpad ! stglab ! manchester ! uk ! ibm ! com
[Download RAW message or body]

Hi Tristan,

Sorry for the slow reply.  (Seem to be saying that a lot lately.)
I was a bit surprised that we didn't have the reloc counts more easily
available, but I see what you mean.

Tristan Gingold <gingold@adacore.com> writes:
> +  if (info->strip != strip_all)
> +    {
> +      /* There can be additional sections just for dealing with overflow in
> +	 reloc and lineno counts. But the numbers of relocs and lineno aren't
> +	 known zhen bfd_sizeof_headers is called, so we compute them by

Typo: s/zhen/when/.

> +	 summing the numbers from input sections.  */
> +      struct nbr_reloc_lineno
> +      {
> +	unsigned int nbr_relocs;
> +	unsigned int nbr_lineno;
> +      };

Very minor, sorry, but I think the code would be easier to follow if these
two fields had the same name as the thing they're summing (reloc_count
and lineno_count).

OK with those changes, thanks.  Good spot!

Richard

[prev in list] [next in list] [prev in thread] [next in thread]