[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    [COMMITTED PATCH] tweak ehdr-start test case to use rodata
From:       Roland McGrath <mcgrathr () google ! com>
Date:       2012-11-30 21:14:56
Message-ID: CAB=4xhq=4=_M0-wK8ccQ9SdneF2=ZF0KfzX41hwDDpAh3AFzGA () mail ! gmail ! com
[Download RAW message or body]

After recent fixes, the test for __ehdr_start began failing on *-*-nacl*
targets.  That's because it created an object with no .rodata-like sections
at all, which means there is no segment that contains the ELF headers and
so __ehdr_start is not set.  This fixes the test to put the reference to
__ehdr_start in .rodata rather than .data so there will always be a
read-only data segment even if it's not the executable one.

I'm committing this to trunk and 2.23 now.


Thanks,
Roland


ld/testsuite/
2012-11-30  Roland McGrath  <mcgrathr@google.com>

	* ld-elf/ehdr_start.s: Put reference in .rodata section, not .data.

--- a/ld/testsuite/ld-elf/ehdr_start.s
+++ b/ld/testsuite/ld-elf/ehdr_start.s
@@ -3,7 +3,7 @@
 _start:
 	.space 16

-	.data
+	.section .rodata,"a"
 	.globl foo
 foo:
 	.weak __ehdr_start

[prev in list] [next in list] [prev in thread] [next in thread]