[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: [PATCH] MIPS/BFD: Correct/clean up ELF FP attribute warning messages
From:       Richard Sandiford <rdsandiford () googlemail ! com>
Date:       2012-11-29 20:19:46
Message-ID: 8738zs40wt.fsf () talisman ! default
[Download RAW message or body]

"Maciej W. Rozycki" <macro@codesourcery.com> writes:
> On Wed, 21 Nov 2012, Maciej W. Rozycki wrote:
>
>> > While you're changing the errors anyway, it might be worth replacing
>> > the two quoted options with %s and using -msoft-float and -mhard-float
>> > instead of "soft float" and "hard float".  Hopefully that wins on user
>> > interface grounds (we consistently reference an option) and means we
>> > always use the same format string.  Just a suggestion though.
>> 
>>  Agreed, quoting the options makes sense to me and I didn't like these 
>> "soft float" messages either, I just didn't feel motivated enough to think 
>> what to do about them. ;)
>
>  Additionally the delegation of option names into substituted strings 
> removed the message variations, addressing your other concern.  On the 
> other hand the extra diagnostics provided for unknown attributes 
> multiplied the original message into three.  I hope this is a good 
> trade-off overall though.

Looks good.

>  So here's the final version, no regressions across the usual MIPS 
> targets.  OK to apply?

Yes, thanks.

Richard

[prev in list] [next in list] [prev in thread] [next in thread]