[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: script-type test fails on ARM
From:       "Kirill A. Shutemov" <kirill () shutemov ! name>
Date:       2010-03-31 16:24:22
Message-ID: o2tcc557aab1003310924m49885bc5z8f0f669ef277863b () mail ! gmail ! com
[Download RAW message or body]

On Wed, Mar 31, 2010 at 4:29 PM, Matthew Gretton-Dann
<matthew.gretton-dann@arm.com> wrote:
> Hi,
>
> On Mon, 2010-03-22 at 23:56 +0200, Kirill A. Shutemov wrote:
>> I've got problem with script-type test on ARM:
> [snip]
>> So, there is one extra line with $a comparing to script-type.sym.
>> It's binutils-2.20.51-2010-03-22.
>>
>> Any ideas how to fix it?
>
> Please find attached a patch that fixes this issue. =C2=A0There is nothing
> wrong with the behaviour of the tools - rather the testsuite was
> expecting incorrect output.
>
> (The $d at 0x10 refers to the output of the .word directive in the
> assembler, and the $a at 0x14 refers to the no-op intructions inserted
> by the .p2align directive immediately after.
>
> Suggested ChangeLog:
>
> 2010-03-31 =C2=A0Matthew Gretton-Dann =C2=A0<matthew.gretton-dann@arm.com>
>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0* ld-arm/script-type.sym: Fix test.
>
> Please can someone review and approve?

I've used identical patch to build my binutils.

Acked-by: Kirill A. Shutemov <kirill@shutemov.name>

[prev in list] [next in list] [prev in thread] [next in thread]