[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: [PATCH] m68000 ELF + two m68k gas fixes
From:       Andreas Schwab <schwab () suse ! de>
Date:       2001-12-27 22:49:38
Message-ID: jeitasjn25.fsf () sykes ! suse ! de
[Download RAW message or body]

Matt Fredette <fredette@theory.lcs.mit.edu> writes:

|> 	[ for gas/ChangeLog ]
|> Tue Dec 18 12:33:01 2001  Matt Fredette  <fredette@netbsd.org>
|> 
|> 	* config/tc-m68k.h (md_prepare_relax_scan): Force relaxation
|> 	into word mode for zero-displacement unconditional absolute 
|> 	jumps, too, otherwise they get assembled incorrectly.

FWIW, this is broken since revision 1.11 of tc-m68k.c, where the
relaxation was redesigned.  The hardcoding in md_prepare_relax_scan should
probably be prominently documented in the comment for md_relax_table.  And
btw, you need to check for this_step == 0 and this_step == 12 as well, as
there are now four cases where disp == 0 provokes an error in
tc-m68k.c:md_convert_frag_1.

Andreas.

-- 
Andreas Schwab                                  "And now for something
Andreas.Schwab@suse.de				completely different."
SuSE Labs, SuSE GmbH, Schanzäckerstr. 10, D-90443 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5

[prev in list] [next in list] [prev in thread] [next in thread]