[prev in list] [next in list] [prev in thread] [next in thread] 

List:       binutils
Subject:    Re: h8300-elf port: gas patches
From:       law () redhat ! com
Date:       2001-08-30 20:42:24
Message-ID: 21705.999204280 () localhost ! localdomain
[Download RAW message or body]


  In message <200108302031.f7UKV5c30624@phal.cambridge.redhat.com>you write:
  > gas/testsuite:
  > 
  > 	* gas/h8300/h8300.exp (do_h8300_cbranch): Remove invocation.
  > 	(do_h8300_branch, do_h8300h_cbranch, do_h8300h_branch): Likewise.
  > 	(do_h8300s_cbranch, do_h8300s_branch, ffxx1): Likwise.
  > 	* gas/h8300/h8300-coff.exp, gas/h8300/h8300-elf.exp: New files.
  > 	* gas/h8300/branch-elf.s, gas/h8300/branchh-elf.s: Likewise.
  > 	* gas/h8300/branchs-elf.s, gas/h8300/ffxx1-elf.d: Likewise.
  > 	* gas/h8300/ffxx1-elf.s: Likewise.
  > 	* gas/h8300/branch.s, gas/h8300/branchh.s: Move to:
  > 	* gas/h8300/branch-coff.s, gas/h8300/branchh-coff.s
  > 	* gas/h8300/branchs.s, gas/h8300/ffxx1.d: Move to:
  > 	* gas/h8300/branchs-coff.s, gas/h8300/ffxx1-coff.d .
  > 	* gas/h8300/ffxx1.s: Move to:
  > 	* gas/h8300/ffxx1-coff.s .
  > 	* lib/gas-defs.exp: (regexp_diff) At verbosity 3, also show
  > 	where mismatch occurs due to regexp mismatch.
These are basically OK.  The only change I would request:

  > + if [istarget h8300*-*-coff] then {

h8300-*-hms* and h8300-*-rtems* also use the COFF port, so this test should
probably be run for them too.  

Make that change and the testsuite bits are OK.

jeff




[prev in list] [next in list] [prev in thread] [next in thread]