[prev in list] [next in list] [prev in thread] [next in thread] 

List:       batik-dev
Subject:    DO NOT REPLY [Bug 48182] NPE when resolving subsitutions for arabic
From:       bugzilla () apache ! org
Date:       2010-09-04 12:01:27
Message-ID: 201009041201.o84C1RnP004691 () thor ! apache ! org
[Download RAW message or body]

https://issues.apache.org/bugzilla/show_bug.cgi?id=48182

Helder Magalhães <helder.magalhaes@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24520|0                           |1
        is obsolete|                            |

--- Comment #5 from Helder Magalhães <helder.magalhaes@gmail.com> 2010-09-04 08:01:25 EDT ---
Created an attachment (id=25987)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25987)
Proposed fix v2

(In reply to comment #0)
> Quick fix, dunno if it's safe to proceed if only one or two of the tree
> subsitutions were found, so I opted for the tripple-check, feel free to change.

Yes, I've checked that the code later invoked in getGlyphAsSVG verifies each of
them independently, so I've updated your patch proposal so that the checks are
also independently made. :-)

I've verified that, with the patch applied, the issue no longer occurs,
although I'd like you to confirm it as well before committing it.

@Keith Grennan
Please confirm that the patch fixes the issue with your problematic font,
otherwise please attach it as requested in comment 3. ;-)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]