[prev in list] [next in list] [prev in thread] [next in thread] 

List:       axis-c-dev
Subject:    [jira] Commented: (AXIS2C-121) Log implementation does not go
From:       "Pim Philipse (JIRA)" <jira () apache ! org>
Date:       2008-10-15 11:33:44
Message-ID: 1601135915.1224070424518.JavaMail.jira () brutus
[Download RAW message or body]


    [ https://issues.apache.org/jira/browse/AXIS2C-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639818#action_12639818 \
] 

Pim Philipse commented on AXIS2C-121:
-------------------------------------

While you're at it,

axutil_log_impl_log_user(
...
        if (AXIS2_LOG_LEVEL_DEBUG <= log->level)
        {
            char value[AXIS2_LEN_VALUE + 1];
            va_list ap;
            va_start(ap, format);
            AXIS2_VSNPRINTF(value, AXIS2_LEN_VALUE, format, ap);
            va_end(ap);
            axutil_log_impl_write_to_file(log, mutex, AXIS2_LOG_LEVEL_DEBUG,
                filename, linenumber, value);
        }

1: change AXIS2_LOG_LEVEL_DEBUG to AXIS2_LOG_LEVEL_USER
2: Some of the members of the enum have a misleading comment:
        /** Warning level, logs only warnings */
        AXIS2_LOG_LEVEL_WARNING,
which is of course not true, as axutil_log_impl_log_warning() has as condition:
        if (AXIS2_LOG_LEVEL_WARNING <= log->level &&
            log->level != AXIS2_LOG_LEVEL_USER)
3: I think messages with AXIS2_LOG_LEVEL_USER should always be passed, so the whole \
if-statement can be omitted in my opinion.


> Log implementation does not go through ops
> ------------------------------------------
> 
> Key: AXIS2C-121
> URL: https://issues.apache.org/jira/browse/AXIS2C-121
> Project: Axis2-C
> Issue Type: Improvement
> Components: util
> Environment: Linux/Windows
> Reporter: Nabeel Yoosuf
> Assignee: Samisa Abeysinghe
> Priority: Minor
> Fix For: 1.0.0
> 
> 
> The log implemenation does not go through ops; as a result of that a user cannot \
> plug his/her log implementation to use the engine. It would be better if we can \
> have it aleast for Linux since there's a known problem with accessing fucntions \
> with variable no of arguments through macros in windows.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-c-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-c-dev-help@ws.apache.org


[prev in list] [next in list] [prev in thread] [next in thread]